Fix gpu_video_decode_accelerator include order by renaming enum with X11 name collision

media/gpu/ipc/service/gpu_video_decode_accelerator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// TODO(markdittmer): This shouldn't be necessary.
-// Ensure that X11 headers don't poison environment before macro headers are
-// loaded.
-//
-// In particular, X11/Xlib.h defines "Status", which is the name of an enum
-// defined in "base/tracked_objects.h", which is eventually required by
-// "ipc/ipc_message_macros.h".
-#include "ipc/ipc_message_macros.h"

[dcheng, 2016/05/06 19:24:00]

I'm not sure which header is doing it, but that header probably shouldn't be
including X11. We try to remove X11 #includes from public headers as much as
possible, to prevent this very problem.

[piman, 2016/05/06 19:46:47]

Agreed - do we know what includes Xlib.h here?

[Mark Dittmer, 2016/05/09 15:12:41]

The relevant preprocessor trace is as follows:

# 19 "../../media/gpu/ipc/service/gpu_video_decode_accelerator.h" 2
# 22 "../../gpu/command_buffer/service/texture_manager.h" 2
# 14 "../../gpu/command_buffer/service/gl_utils.h"
# 22 "../../ui/gl/gl_bindings.h" 2
# 39 "../../third_party/khronos/EGL/egl.h"
# 106 "../../third_party/khronos/EGL/eglplatform.h"
# 1 "/usr/include/X11/Xlib.h" 1 3 4

This shows up on GYP chromeos builds (e.g., build [1] on issue [2]).

[1]
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
[2] https://codereview.chromium.org/1958903004

-
 #include "media/gpu/ipc/service/gpu_video_decode_accelerator.h"
 
 #include <memory>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/single_thread_task_runner.h"
 #include "base/stl_util.h"
 #include "base/thread_task_runner_handle.h"
 #include "build/build_config.h"
 #include "gpu/command_buffer/common/command_buffer.h"
 #include "gpu/command_buffer/service/gpu_preferences.h"
 #include "gpu/ipc/service/gpu_channel.h"
 #include "gpu/ipc/service/gpu_channel_manager.h"
+#include "ipc/ipc_message_macros.h"
 #include "ipc/ipc_message_utils.h"
 #include "ipc/message_filter.h"
 #include "media/base/limits.h"
 #include "media/gpu/gpu_video_accelerator_util.h"
 #include "media/gpu/gpu_video_decode_accelerator_factory_impl.h"
 #include "media/gpu/ipc/common/media_messages.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gl/gl_context.h"
 #include "ui/gl/gl_image.h"
 
@@ skipping 484 matching lines @@
     GLenum target = texture_ref->texture()->target();
     gpu::gles2::TextureManager* texture_manager =
         stub_->decoder()->GetContextGroup()->texture_manager();
     DCHECK(!texture_ref->texture()->IsLevelCleared(target, 0));
     texture_manager->SetLevelCleared(texture_ref.get(), target, 0, true);
   }
   uncleared_textures_.erase(it);
 }
 
 }  // namespace media