When filling nested rect path check for empty inner and empty outer rects

When filling nested rect path check for empty inner and empty outer rects

BUG=skia:5221
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1936073003

Committed: https://skia.googlesource.com/skia/+/40ef48580b8bd47355ccf05e43d8032c10a77bbe

[bsalomon, 2016-05-02 17:56:15]

Description was changed from

==========
When filling nested rect path check for empty inner and empty outer rects

BUG=skia:5221
==========

to

==========
When filling nested rect path check for empty inner and empty outer rects

BUG=skia:5221
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-05-02 18:54:30]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-05-02 19:15:23]

https://codereview.chromium.org/1936073003/diff/20001/src/gpu/batches/GrRectB...
File src/gpu/batches/GrRectBatchFactory.cpp (right):

https://codereview.chromium.org/1936073003/diff/20001/src/gpu/batches/GrRectB...
src/gpu/batches/GrRectBatchFactory.cpp:28: }
Here we pass down the viewMatrix & the untransformed rect

https://codereview.chromium.org/1936073003/diff/20001/src/gpu/batches/GrRectB...
src/gpu/batches/GrRectBatchFactory.cpp:31: 
but here we pass down the viewMatrix and the two transformed rects ?

https://codereview.chromium.org/1936073003/diff/20001/tests/skbug5221.cpp
File tests/skbug5221.cpp (right):

https://codereview.chromium.org/1936073003/diff/20001/tests/skbug5221.cpp#new...
tests/skbug5221.cpp:15: SkPath path;
Shouldn't we be jamming two rects into this path ?

[bsalomon, 2016-05-02 19:45:28]

https://codereview.chromium.org/1936073003/diff/20001/src/gpu/batches/GrRectB...
File src/gpu/batches/GrRectBatchFactory.cpp (right):

https://codereview.chromium.org/1936073003/diff/20001/src/gpu/batches/GrRectB...
src/gpu/batches/GrRectBatchFactory.cpp:28: }
On 2016/05/02 19:15:22, robertphillips wrote:
> Here we pass down the viewMatrix & the untransformed rect

you're right, this is supposed to be the dev rect

https://codereview.chromium.org/1936073003/diff/20001/tests/skbug5221.cpp
File tests/skbug5221.cpp (right):

https://codereview.chromium.org/1936073003/diff/20001/tests/skbug5221.cpp#new...
tests/skbug5221.cpp:15: SkPath path;
On 2016/05/02 19:15:22, robertphillips wrote:
> Shouldn't we be jamming two rects into this path ?

Oops.. meant to delete the path and just draw the text.

Anything but text gets nuked at the canvas level because of the matrix.

[robertphillips, 2016-05-02 19:53:12]

lgtm

https://codereview.chromium.org/1936073003/diff/40001/tests/skbug5221.cpp
File tests/skbug5221.cpp (right):

https://codereview.chromium.org/1936073003/diff/40001/tests/skbug5221.cpp#new...
tests/skbug5221.cpp:9: #include "SkCanvas.h"
Can we rm SkPath.h now ?

[bsalomon, 2016-05-02 19:57:51]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-05-02 19:57:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1936073003/#ps60001
(title: "rm skpath.h include")

[bsalomon, 2016-05-02 19:57:54]

https://codereview.chromium.org/1936073003/diff/40001/tests/skbug5221.cpp
File tests/skbug5221.cpp (right):

https://codereview.chromium.org/1936073003/diff/40001/tests/skbug5221.cpp#new...
tests/skbug5221.cpp:9: #include "SkCanvas.h"
On 2016/05/02 19:53:12, robertphillips wrote:
> Can we rm SkPath.h now ?

indeed

[commit-bot: I haz the power, 2016-05-02 19:57:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936073003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936073003/60001

[commit-bot: I haz the power, 2016-05-02 20:22:16]

Description was changed from

==========
When filling nested rect path check for empty inner and empty outer rects

BUG=skia:5221
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
When filling nested rect path check for empty inner and empty outer rects

BUG=skia:5221
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/40ef48580b8bd47355ccf05e43d8032c10a77bbe
==========

[commit-bot: I haz the power, 2016-05-02 20:22:16]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/40ef48580b8bd47355ccf05e43d8032c10a77bbe