Issue 1936053002: [Password Manager] Add federations to sort key on password page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1936053002: [Password Manager] Add federations to sort key on password page (Closed)

Created:
4 years, 7 months ago by vasilii

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

[Password Manager] Add federations to sort key on password page If federations are not included into sort key, entries with the same origin, username and password, but different federation will be collapsed into one entry. That is not correct. BUG=604750 Review-Url: https://codereview.chromium.org/1927753003 Cr-Commit-Position: refs/heads/master@{#390457} (cherry picked from commit 7c82fec6686c0ee3b38bb70d86d0f0c1837127c9) Committed: https://chromium.googlesource.com/chromium/src/+/3877e40f5ac8fc8a45aabab1be84a2472abaadff

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -59 lines)			Patch
M	chrome/browser/ui/passwords/password_manager_presenter.h	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/passwords/password_manager_presenter.cc	View	8 chunks	+19 lines, -17 lines	0 comments	Download
M	chrome/browser/ui/passwords/password_manager_presenter_unittest.cc	View	7 chunks	+63 lines, -38 lines	0 comments	Download

Total messages: 2 (1 generated)

vasilii

4 years, 7 months ago (2016-05-02 11:35:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3877e40f5ac8fc8a45aabab1be84a2472abaadff.