Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm

Issue 1935993004: MacViews: support Views permission bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo in chrome_browser_ui.gypi Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
index cea377c7f5e332760b9f968849d96c9efd837ff1..03d29587d2821f0eb32e2732ab2434eff125abc7 100644
--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
@@ -48,14 +48,14 @@
@end
@implementation MockBubbleYesLocationBar
-- (bool)hasVisibleLocationBar { return true; }
++ (bool)hasVisibleLocationBarForBrowser:(Browser*)browser { return true; }
@end
@interface MockBubbleNoLocationBar : NSObject
@end
@implementation MockBubbleNoLocationBar
-- (bool)hasVisibleLocationBar { return false; }
++ (bool)hasVisibleLocationBarForBrowser:(Browser*)browser { return false; }
@end
namespace {
@@ -353,7 +353,7 @@ TEST_F(PermissionBubbleControllerTest, ExitFullscreen) {
TEST_F(PermissionBubbleControllerTest, AnchorPositionWithLocationBar) {
base::mac::ScopedObjCClassSwizzler locationSwizzle(
[PermissionBubbleController class], [MockBubbleYesLocationBar class],
- @selector(hasVisibleLocationBar));
+ @selector(hasVisibleLocationBarForBrowser:));
NSPoint anchor = [controller_ getExpectedAnchorPoint];
@@ -370,7 +370,7 @@ TEST_F(PermissionBubbleControllerTest, AnchorPositionWithLocationBar) {
TEST_F(PermissionBubbleControllerTest, AnchorPositionWithoutLocationBar) {
base::mac::ScopedObjCClassSwizzler locationSwizzle(
[PermissionBubbleController class], [MockBubbleNoLocationBar class],
- @selector(hasVisibleLocationBar));
+ @selector(hasVisibleLocationBarForBrowser:));
NSPoint anchor = [controller_ getExpectedAnchorPoint];
@@ -388,7 +388,7 @@ TEST_F(PermissionBubbleControllerTest,
{
base::mac::ScopedObjCClassSwizzler locationSwizzle(
[PermissionBubbleController class], [MockBubbleYesLocationBar class],
- @selector(hasVisibleLocationBar));
+ @selector(hasVisibleLocationBarForBrowser:));
withLocationBar = [controller_ getExpectedAnchorPoint];
}
@@ -396,7 +396,7 @@ TEST_F(PermissionBubbleControllerTest,
{
base::mac::ScopedObjCClassSwizzler locationSwizzle(
[PermissionBubbleController class], [MockBubbleNoLocationBar class],
- @selector(hasVisibleLocationBar));
+ @selector(hasVisibleLocationBarForBrowser:));
withoutLocationBar = [controller_ getExpectedAnchorPoint];
}

Powered by Google App Engine
This is Rietveld 408576698