third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js - Issue 1935993003: SELECT element: Ignore synthetic events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js

Issue 1935993003: SELECT element: Ignore synthetic events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix openPicker() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js ('k') | third_party/WebKit/LayoutTests/fast/forms/select/menulist-popup-open-by-synthetic-event.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js

diff --git a/third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js b/third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js

index d971330938ce84a2278291f1cbdbfa95753ebe4f..c6e14e3d2744483adc7c1b7ab0086ba0e5753855 100644

--- a/third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js

+++ b/third_party/WebKit/LayoutTests/fast/forms/resources/picker-common.js

@@ -44,7 +44,7 @@ function openPicker(element, callback, errorCallback) {

element.offsetTop; // Force to lay out

element.focus();

if (element.tagName === "SELECT") {

- sendKey(element, "Down", false, true);

+ eventSender.keyDown("downArrow", ["altKey"]);

} else if (element.tagName === "INPUT") {

if (element.type === "color") {

element.focus();