mojo: Fix leveldb unittests by making fs::Directories cloneable.

components/leveldb/leveldb_service_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/bind.h"
 #include "base/macros.h"
 #include "components/filesystem/public/interfaces/directory.mojom.h"
 #include "components/filesystem/public/interfaces/file_system.mojom.h"
 #include "components/filesystem/public/interfaces/types.mojom.h"
 #include "components/leveldb/public/interfaces/leveldb.mojom.h"
 #include "mojo/common/common_type_converters.h"
 #include "mojo/public/cpp/bindings/binding_set.h"
 #include "mojo/util/capture_util.h"
 #include "services/shell/public/cpp/shell_connection.h"
 #include "services/shell/public/cpp/shell_test.h"
@@ skipping 18 matching lines @@
   }
 
   void TearDown() override {
     leveldb_.reset();
     files_.reset();
     ShellTest::TearDown();
   }
 
   // Note: This has an out parameter rather than returning the |DirectoryPtr|,
   // since |ASSERT_...()| doesn't work with return values.
-  void GetUserDataDir(filesystem::DirectoryPtr* directory) {
+  void GetTempDirectory(filesystem::DirectoryPtr* directory) {
     FileError error = FileError::FAILED;
-    files()->OpenPersistentFileSystem(GetProxy(directory),
-                                      mojo::Capture(&error));
+    files()->OpenTempDirectory(GetProxy(directory), mojo::Capture(&error));
     ASSERT_TRUE(files().WaitForIncomingResponse());
     ASSERT_EQ(FileError::OK, error);
   }
 
   filesystem::FileSystemPtr& files() { return files_; }
   LevelDBServicePtr& leveldb() { return leveldb_; }
 
  private:
   filesystem::FileSystemPtr files_;
   LevelDBServicePtr leveldb_;
@@ skipping 123 matching lines @@
   // Reading "key" should be invalid now.
   error = DatabaseError::INVALID_ARGUMENT;
   value = nullptr;
   database->Get(mojo::Array<uint8_t>::From(std::string("prefix-key2")),
                 Capture(&error, &value));
   ASSERT_TRUE(database.WaitForIncomingResponse());
   EXPECT_EQ(DatabaseError::NOT_FOUND, error);
   EXPECT_EQ("", value.To<std::string>());
 }
 
-// TODO(crbug.com/602820) Test is flaky.
-#if defined(OS_LINUX) || defined(OS_WIN)
-#define MAYBE_Reconnect DISABLED_Reconnect
-#else
-#define MAYBE_Reconnect Reconnect
-#endif
-TEST_F(LevelDBServiceTest, MAYBE_Reconnect) {
+TEST_F(LevelDBServiceTest, Reconnect) {
   DatabaseError error;
 
+  filesystem::DirectoryPtr temp_directory;
+  GetTempDirectory(&temp_directory);
+
   {
     filesystem::DirectoryPtr directory;
-    GetUserDataDir(&directory);
+    temp_directory->Clone(GetProxy(&directory));
 
     LevelDBDatabasePtr database;
-    leveldb()->Open(std::move(directory), "test", GetProxy(&database),
-                    Capture(&error));
+    leveldb::OpenOptionsPtr options = leveldb::OpenOptions::New();
+    options->error_if_exists = true;
+    options->create_if_missing = true;
+    leveldb()->OpenWithOptions(std::move(options),
+                               std::move(directory), "test",
+                               GetProxy(&database),
+                               Capture(&error));
     ASSERT_TRUE(leveldb().WaitForIncomingResponse());
     EXPECT_EQ(DatabaseError::OK, error);
 
     // Write a key to the database.
     error = DatabaseError::INVALID_ARGUMENT;
     database->Put(mojo::Array<uint8_t>::From(std::string("key")),
                   mojo::Array<uint8_t>::From(std::string("value")),
                   Capture(&error));
     ASSERT_TRUE(database.WaitForIncomingResponse());
     EXPECT_EQ(DatabaseError::OK, error);
 
     // The database should go out of scope here.
   }
 
   {
     filesystem::DirectoryPtr directory;
-    GetUserDataDir(&directory);
+    temp_directory->Clone(GetProxy(&directory));
 
     // Reconnect to the database.
     LevelDBDatabasePtr database;
     leveldb()->Open(std::move(directory), "test", GetProxy(&database),
                     Capture(&error));
     ASSERT_TRUE(leveldb().WaitForIncomingResponse());
     EXPECT_EQ(DatabaseError::OK, error);
 
     // We should still be able to read the key back from the database.
     error = DatabaseError::INVALID_ARGUMENT;
@@ skipping 257 matching lines @@
   key_values.SetToEmpty();
   database->GetPrefixed(mojo::Array<uint8_t>::From(prefix),
                         Capture(&error, &key_values));
   ASSERT_TRUE(database.WaitForIncomingResponse());
   EXPECT_EQ(DatabaseError::OK, error);
   EXPECT_TRUE(key_values.empty());
 }
 
 }  // namespace
 }  // namespace leveldb