Issue 193583002: Use new is*Element() helper functions in inspector code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193583002: Use new is*Element() helper functions in inspector code (Closed)

Created:
6 years, 9 months ago by Inactive

Modified:
6 years, 9 months ago

Reviewers:
adamk, pfeldman, eseidel

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use new is*Element() helper functions in inspector code Use new is*Element() helpers in inspector code. This makes the code clearer and simpler. R=eseidel, adamk BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168916

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -32 lines)			Patch
M	Source/core/inspector/DOMPatchSupport.cpp	View	7 chunks	+10 lines, -13 lines	0 comments	Download
M	Source/core/inspector/InspectorCanvasAgent.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/inspector/InspectorDOMAgent.cpp	View	4 chunks	+11 lines, -12 lines	0 comments	Download
M	Source/core/inspector/InspectorStyleSheet.cpp	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/193583002/1

6 years, 9 months ago (2014-03-11 12:21:45 UTC) #4

Message was sent while issue was closed.

Change committed as 168916

Expand Messages | Collapse Messages