Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1935823002: include type parameters on generic sync/async functions (Closed)

Created:
4 years, 7 months ago by Harry Terkelsen
Modified:
4 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

include type parameters on generic sync/async functions fixes #538 R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/8a23cd35a4cdba5b8d9359e52a3f83c72e907c18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M lib/src/compiler/code_generator.dart View 1 chunk +1 line, -0 lines 0 comments Download
A + test/codegen/language/generic_async_star_test.dart View 1 chunk +12 lines, -3 lines 0 comments Download
A + test/codegen/language/generic_async_test.dart View 1 chunk +6 lines, -3 lines 0 comments Download
A + test/codegen/language/generic_sync_star_test.dart View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 7 months ago (2016-04-29 22:21:56 UTC) #2
Jennifer Messerly
LGTM!
4 years, 7 months ago (2016-04-29 22:25:22 UTC) #3
Harry Terkelsen
4 years, 7 months ago (2016-04-29 22:26:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a23cd35a4cdba5b8d9359e52a3f83c72e907c18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698