Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 1935703002: - reset 'dirty' flag to false after the libraries mirrors is computed, this ensures that we compute… (Closed)

Created:
4 years, 7 months ago by siva
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- reset 'dirty' flag to false after the libraries mirrors is computed, this ensures that we compute the libraries only when new library modules are loaded and the 'dirty' flag is set to true. - Use passed in 'zone' argument in the native string functions - Use passed in 'thread' argument in the library mirror creation functions R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/964a659470344e4dead81d399a340a208e1f29d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -24 lines) Patch
M runtime/lib/mirrors.cc View 9 chunks +14 lines, -12 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/lib/string.cc View 10 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 7 months ago (2016-04-29 19:36:38 UTC) #2
rmacnak
lgtm
4 years, 7 months ago (2016-04-29 20:37:49 UTC) #3
siva
4 years, 7 months ago (2016-04-29 22:15:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
964a659470344e4dead81d399a340a208e1f29d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698