Issue 19357002: Simplify code for getting selected text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19357002: Simplify code for getting selected text. (Closed)

Created:
7 years, 5 months ago by kochi

Modified:
7 years, 5 months ago

Reviewers:
tkent, rniwa-cr

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Simplify code for getting selected text. As suggested by rniwa in review https://chromiumcodereview.appspot.com/18041002/ This will match the corresponding change in WebKit: https://bugs.webkit.org/show_bug.cgi?id=118684 BUG=none TEST=layouttest Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154331

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	Source/core/editing/Editor.cpp	View		1 chunk	+1 line, -7 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/19357002/1

7 years, 5 months ago (2013-07-16 20:05:00 UTC) #3

kochi

7 years, 5 months ago (2013-07-17 02:18:31 UTC) #5

Message was sent while issue was closed.

On 2013/07/16 22:50:57, I haz the power (commit-bot) wrote:
> Change committed as 154331

Thanks!