Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2637)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

Issue 1935663002: New origin security indicator icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to comments, and get the colors right on Mac OS X. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
index ccd406829cfb15a36dfa984ea5e07657747e8e49..e3eb02d0db10a62268cee100e8e63b7891dc100f 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
@@ -14,6 +14,7 @@
#include "base/strings/string16.h"
#include "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h"
#include "components/omnibox/browser/omnibox_view.h"
+#include "components/security_state/security_state_model.h"
class CommandUpdater;
class OmniboxPopupView;
@@ -33,6 +34,12 @@ class OmniboxViewMac : public OmniboxView,
public:
static SkColor BaseTextColorSkia(bool in_dark_mode);
static NSColor* BaseTextColor(bool in_dark_mode);
+ static SkColor GetSecureTextColorSkia(
Evan Stade 2016/05/19 17:58:49 you only call this in one place, it doesn't seem l
palmer 2016/05/19 18:40:40 I had it that way at first, but groby suggested in
Peter Kasting 2016/05/19 18:43:21 Simpler is good.
palmer 2016/05/19 19:55:44 Done.
+ security_state::SecurityStateModel::SecurityLevel security_level,
+ bool in_dark_mode);
+ static NSColor* GetSecureTextColor(
+ security_state::SecurityStateModel::SecurityLevel security_level,
+ bool in_dark_mode);
OmniboxViewMac(OmniboxEditController* controller,
Profile* profile,

Powered by Google App Engine
This is Rietveld 408576698