git_cl: Add the ability to set the description. (reland)

git_cl: Add the ability to set the description. (reland)

BUG=607359
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300366

[martiniss, 2016-04-29 18:31:39]

martiniss@chromium.org changed reviewers:
+ tandrii@chromium.org

[martiniss, 2016-04-29 18:31:40]

Ok, re-uploaded, and tested locally! PTAL

[tandrii(chromium), 2016-04-29 18:53:44]

LGTM if you fix first comment

https://codereview.chromium.org/1935653002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1935653002/diff/1/git_cl.py#newcode3315
git_cl.py:3315: text = '\n'.join(l.strip() for l in sys.stdin)
s/strip/rstrip

this is important, as you don't want to re-format indentation in
  messages
    like these :)

https://codereview.chromium.org/1935653002/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/1935653002/diff/1/tests/git_cl_test.py#newcod...
tests/git_cl_test.py:1447: self.mock(git_cl.sys, 'stdin',
StringIO.StringIO('hi\nthere'))
how about changing input to
'hi \r\n\t there '
just to make sure we work as intended to receive
'hi\n\t there'

[tandrii(chromium), 2016-04-29 18:56:17]

https://codereview.chromium.org/1935653002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1935653002/diff/1/git_cl.py#newcode3296
git_cl.py:3296: target_issue = issue_arg.issue
issue_arg may potentially contain server host. It's not crucial for this CL
though, but FYI for http://crbug.com/607990

[martiniss, 2016-04-29 19:19:05]

https://codereview.chromium.org/1935653002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1935653002/diff/1/git_cl.py#newcode3296
git_cl.py:3296: target_issue = issue_arg.issue
On 2016/04/29 at 18:56:17, tandrii(chromium) wrote:
> issue_arg may potentially contain server host. It's not crucial for this CL
though, but FYI for http://crbug.com/607990

I see. I'll look at this later, thanks.

https://codereview.chromium.org/1935653002/diff/1/git_cl.py#newcode3315
git_cl.py:3315: text = '\n'.join(l.strip() for l in sys.stdin)
On 2016/04/29 at 18:53:44, tandrii(chromium) wrote:
> s/strip/rstrip
> 
> this is important, as you don't want to re-format indentation in
>   messages
>     like these :)

Fixed, thanks.

https://codereview.chromium.org/1935653002/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/1935653002/diff/1/tests/git_cl_test.py#newcod...
tests/git_cl_test.py:1447: self.mock(git_cl.sys, 'stdin',
StringIO.StringIO('hi\nthere'))
On 2016/04/29 at 18:53:44, tandrii(chromium) wrote:
> how about changing input to
> 'hi \r\n\t there '
> just to make sure we work as intended to receive
> 'hi\n\t there'

Changed, good idea.

[martiniss, 2016-04-29 19:19:10]

The CQ bit was checked by martiniss@chromium.org

[martiniss, 2016-04-29 19:19:10]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1935653002/#ps40001
(title: "Better test.")

[commit-bot: I haz the power, 2016-04-29 19:19:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935653002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935653002/40001

[commit-bot: I haz the power, 2016-04-29 19:22:17]

Description was changed from

==========
git_cl: Add the ability to set the description. (reland)

BUG=607359
==========

to

==========
git_cl: Add the ability to set the description. (reland)

BUG=607359

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300366
==========

[commit-bot: I haz the power, 2016-04-29 19:22:18]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300366