Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issue 1935563002: Revert of Implement owners check in presubmit for Gerrit. (Closed)

Created:
4 years, 7 months ago by tandrii(chromium)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@P300
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Implement owners check in presubmit for Gerrit. (patchset #5 id:80001 of https://codereview.chromium.org/1927773002/ ) Reason for revert: now it doesn't work for gerrit. Damn it. Original issue's description: > Implement owners check in presubmit for Gerrit. > > R=machenbach@chromium.org,phajdan.jr@chromium.org > BUG=605563 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300350 TBR=machenbach@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605563 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -196 lines) Patch
M git_cl.py View 3 chunks +1 line, -9 lines 0 comments Download
M presubmit_canned_checks.py View 3 chunks +11 lines, -46 lines 0 comments Download
M presubmit_support.py View 11 chunks +19 lines, -86 lines 0 comments Download
M tests/presubmit_unittest.py View 11 chunks +9 lines, -55 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
tandrii(chromium)
Created Revert of Implement owners check in presubmit for Gerrit.
4 years, 7 months ago (2016-04-29 16:33:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935563002/1
4 years, 7 months ago (2016-04-29 16:33:12 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 16:33:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300352

Powered by Google App Engine
This is Rietveld 408576698