Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1935553003: [Media Router WebUI] Move calls in ready() and attached() to afterNextRender(). (Closed)

Created:
4 years, 7 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Move calls in ready() and attached() to afterNextRender(). This allows the dialog to render before doing most of the setup work (e.g. event handlers). Some calls (e.g. initial view state) is still called in ready(). Also removes a noop updateElementPositioning_() call. BUG=549289 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f4e1990eeb5c6e9e629feb160452a4774d4e0abd Cr-Commit-Position: refs/heads/master@{#391385}

Patch Set 1 : #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -60 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 1 chunk +19 lines, -21 lines 0 comments Download
M chrome/test/data/webui/media_router/media_router_container_filter_tests.js View 1 4 chunks +49 lines, -39 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
apacible
PTAL, thanks!
4 years, 7 months ago (2016-04-29 19:03:37 UTC) #4
imcheng
lgtm
4 years, 7 months ago (2016-05-03 20:35:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935553003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935553003/60001
4 years, 7 months ago (2016-05-03 21:51:19 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 7 months ago (2016-05-03 23:05:53 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 23:07:36 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f4e1990eeb5c6e9e629feb160452a4774d4e0abd
Cr-Commit-Position: refs/heads/master@{#391385}

Powered by Google App Engine
This is Rietveld 408576698