Try to unbreak gyp build-only bots after https://codereview.chromium.org/1918143004/

Try to unbreak gyp build-only bots after https://codereview.chromium.org/1918143004/

isolate_tests is failing 'cause the _run target for the newly isolated
test didn't get build.

BUG=604847
R=rockot@chromium.org

Committed: https://crrev.com/3d20aaaab890829087e0870d8116b720685b43a7
Cr-Commit-Position: refs/heads/master@{#390665}

[Nico, 2016-04-29 15:34:24]

thakis@chromium.org changed reviewers:
+ hans@chromium.org, rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-04-29 15:36:46]

https://codereview.chromium.org/1935553002/diff/20001/build/gn_migration.gypi
File build/gn_migration.gypi (right):

https://codereview.chromium.org/1935553002/diff/20001/build/gn_migration.gypi...
build/gn_migration.gypi:645: ['OS!="android" and OS!="ios" and chromecast==0', {
hmm - i thought we were running all of these on android

https://codereview.chromium.org/1935553002/diff/20001/build/gn_migration.gypi...
build/gn_migration.gypi:647: '../ipx/mojo/ipc_mojo.gyp:ipc_mojo_unittests_run',
s/ipx/ipc/

[Nico, 2016-04-29 15:39:04]

Thanks!

https://codereview.chromium.org/1935553002/diff/20001/build/gn_migration.gypi
File build/gn_migration.gypi (right):

https://codereview.chromium.org/1935553002/diff/20001/build/gn_migration.gypi...
build/gn_migration.gypi:645: ['OS!="android" and OS!="ios" and chromecast==0', {
On 2016/04/29 15:36:45, Ken Rockot wrote:
> hmm - i thought we were running all of these on android

\noideanico. I chose this conditional because build/all.gyp depends on
services/shell/shell.gyp with this conditional. What should the conditional be
then? Just drop the OS!=android bit?

https://codereview.chromium.org/1935553002/diff/20001/build/gn_migration.gypi...
build/gn_migration.gypi:647: '../ipx/mojo/ipc_mojo.gyp:ipc_mojo_unittests_run',
On 2016/04/29 15:36:45, Ken Rockot wrote:
> s/ipx/ipc/

Done.

[Ken Rockot(use gerrit already), 2016-04-29 15:41:07]

Nevermind, I lied. We *can* build and run the tests on android, but no android
bots are configured to do so. We can look into addressing that later.

LGTM

[Nico, 2016-04-29 15:42:42]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-04-29 15:43:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935553002/40001

[commit-bot: I haz the power, 2016-04-29 16:22:06]

Description was changed from

==========
Try to unbreak gyp build-only bots after
https://codereview.chromium.org/1918143004/

isolate_tests is failing 'cause the _run target for the newly isolated
test didn't get build.

BUG=604847
==========

to

==========
Try to unbreak gyp build-only bots after
https://codereview.chromium.org/1918143004/

isolate_tests is failing 'cause the _run target for the newly isolated
test didn't get build.

BUG=604847
R=rockot@chromium.org

Committed: https://crrev.com/3d20aaaab890829087e0870d8116b720685b43a7
Cr-Commit-Position: refs/heads/master@{#390665}
==========

[commit-bot: I haz the power, 2016-04-29 16:22:06]

Patchset 3 (id:??) landed as
https://crrev.com/3d20aaaab890829087e0870d8116b720685b43a7
Cr-Commit-Position: refs/heads/master@{#390665}

[Nico, 2016-04-29 16:22:50]

Description was changed from

==========
Try to unbreak gyp build-only bots after
https://codereview.chromium.org/1918143004/

isolate_tests is failing 'cause the _run target for the newly isolated
test didn't get build.

BUG=604847
R=rockot@chromium.org

Committed: https://crrev.com/3d20aaaab890829087e0870d8116b720685b43a7
Cr-Commit-Position: refs/heads/master@{#390665}
==========

to

==========
Try to unbreak gyp build-only bots after
https://codereview.chromium.org/1918143004/

isolate_tests is failing 'cause the _run target for the newly isolated
test didn't get build.

BUG=604847
R=rockot@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/3d20aaaab890829087e0870d8116...
==========

[Nico, 2016-04-29 16:22:52]

Committed patchset #3 (id:40001) manually as
3d20aaaab890829087e0870d8116b720685b43a7 (presubmit successful).

[commit-bot: I haz the power, 2016-04-30 17:26:14]

Description was changed from

==========
Try to unbreak gyp build-only bots after
https://codereview.chromium.org/1918143004/

isolate_tests is failing 'cause the _run target for the newly isolated
test didn't get build.

BUG=604847
R=rockot@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/3d20aaaab890829087e0870d8116...
==========

to

==========
Try to unbreak gyp build-only bots after
https://codereview.chromium.org/1918143004/

isolate_tests is failing 'cause the _run target for the newly isolated
test didn't get build.

BUG=604847
R=rockot@chromium.org

Committed: https://crrev.com/3d20aaaab890829087e0870d8116b720685b43a7
Cr-Commit-Position: refs/heads/master@{#390665}
==========

[commit-bot: I haz the power, 2016-04-30 17:26:15]

Patchset 3 (id:??) landed as
https://crrev.com/3d20aaaab890829087e0870d8116b720685b43a7
Cr-Commit-Position: refs/heads/master@{#390665}