Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 19355002: Add chromium side implementation of WebKit::WebCrypto. (Closed)

Created:
7 years, 5 months ago by eroman
Modified:
7 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add chromium side implementation of WebKit::WebCrypto. This adds the skeleton for the new files, however doesn't fill in any of the details yet. BUG=245025 R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212134

Patch Set 1 #

Patch Set 2 : Remove hacky SHA1 implementation #

Total comments: 2

Patch Set 3 : Add parameter name #

Patch Set 4 : rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M content/content_renderer.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
A content/renderer/webcrypto_impl.h View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A content/renderer/webcrypto_impl.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
eroman
I tested this manually by using patchset 1, along with some blink-side changes in my ...
7 years, 5 months ago (2013-07-16 18:47:37 UTC) #1
abarth-chromium
I'm probably not the right reviewer for the Chromium-side changes. I don't understand the constraints ...
7 years, 5 months ago (2013-07-17 00:01:51 UTC) #2
eroman
James, is this something you could review? The main thing to review here is file ...
7 years, 5 months ago (2013-07-17 00:10:19 UTC) #3
jamesr
Will web workers need/want access to this API? If so then I think you want ...
7 years, 5 months ago (2013-07-17 00:25:16 UTC) #4
eroman
This is renderer only. (It is possible that in a future version of the WebCrypto ...
7 years, 5 months ago (2013-07-17 00:41:04 UTC) #5
jamesr
OK, in that case this lgtm https://codereview.chromium.org/19355002/diff/2001/content/renderer/webcrypto_impl.h File content/renderer/webcrypto_impl.h (right): https://codereview.chromium.org/19355002/diff/2001/content/renderer/webcrypto_impl.h#newcode17 content/renderer/webcrypto_impl.h:17: const WebKit::WebCryptoAlgorithm&) OVERRIDE; ...
7 years, 5 months ago (2013-07-17 00:48:05 UTC) #6
eroman
https://codereview.chromium.org/19355002/diff/2001/content/renderer/webcrypto_impl.h File content/renderer/webcrypto_impl.h (right): https://codereview.chromium.org/19355002/diff/2001/content/renderer/webcrypto_impl.h#newcode17 content/renderer/webcrypto_impl.h:17: const WebKit::WebCryptoAlgorithm&) OVERRIDE; On 2013/07/17 00:48:11, jamesr wrote: > ...
7 years, 5 months ago (2013-07-17 01:23:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/19355002/15001
7 years, 5 months ago (2013-07-17 17:50:45 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-17 19:55:27 UTC) #9
eroman
7 years, 5 months ago (2013-07-17 21:23:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 manually as r212134 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698