Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: tools/perf/page_sets/long_running_idle_google_cases.py

Issue 1935493003: Revert of Port memory.long_running_idle_gmail benchmarks to TBMv2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/memory_infra.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/long_running_idle_google_cases.py
diff --git a/tools/perf/page_sets/long_running_idle_google_cases.py b/tools/perf/page_sets/long_running_idle_google_cases.py
index 302cddf52617a1cf52e9642294046a10040aaa9c..9b46f8c2c96948e5f7db9439595ff795a735977a 100644
--- a/tools/perf/page_sets/long_running_idle_google_cases.py
+++ b/tools/perf/page_sets/long_running_idle_google_cases.py
@@ -6,20 +6,19 @@
from page_sets import google_pages
+STARTUP_TIME_IN_SECONDS = 2
IDLE_TIME_IN_SECONDS = 100
-SAMPLING_INTERVAL_IN_SECONDS = 1
-STEPS = IDLE_TIME_IN_SECONDS / SAMPLING_INTERVAL_IN_SECONDS
-
-def _IdleAction(action_runner):
- action_runner.tab.browser.DumpMemory()
- for _ in xrange(STEPS):
- action_runner.Wait(SAMPLING_INTERVAL_IN_SECONDS)
- action_runner.tab.browser.DumpMemory()
def _CreateIdlePageClass(base_page_cls):
class DerivedIdlePage(base_page_cls): # pylint: disable=no-init
def RunPageInteractions(self, action_runner):
- _IdleAction(action_runner)
+ action_runner.Wait(STARTUP_TIME_IN_SECONDS)
+ with action_runner.CreateInteraction('Begin'):
+ action_runner.tab.browser.DumpMemory()
+ with action_runner.CreateInteraction('Idle'):
+ action_runner.Wait(IDLE_TIME_IN_SECONDS)
+ with action_runner.CreateInteraction('End'):
+ action_runner.tab.browser.DumpMemory()
return DerivedIdlePage
@@ -27,7 +26,7 @@
class DerivedIdlePage(base_page_cls): # pylint: disable=no-init
def RunPageInteractions(self, action_runner):
action_runner.tab.browser.tabs.New()
- _IdleAction(action_runner)
+ action_runner.Wait(IDLE_TIME_IN_SECONDS)
return DerivedIdlePage
« no previous file with comments | « tools/perf/benchmarks/memory_infra.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698