Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h

Issue 1935493002: Refactor SVGTextLayoutEngine::currentLogicalCharacterMetrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add ASSERTs Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h
diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h
index cdac5757fdb34d34d0ea7a167e02fecfbf29de03..368551b92dca49a54e16a0bc3aee9c6fcd40c012 100644
--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h
+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h
@@ -71,19 +71,19 @@ private:
void layoutInlineTextBox(SVGInlineTextBox*);
void layoutTextOnLineOrPath(SVGInlineTextBox*, LineLayoutSVGInlineText, const ComputedStyle&);
- bool currentLogicalCharacterAttributes(SVGTextLayoutAttributes*&);
- bool currentLogicalCharacterMetrics(SVGTextLayoutAttributes*&, SVGTextMetrics&);
+ const SVGTextLayoutAttributes* nextLogicalAttributes();
+ const SVGTextLayoutAttributes* currentLogicalCharacterMetrics(SVGTextMetrics&);
void advanceToNextLogicalCharacter(const SVGTextMetrics&);
-private:
+ // Logical iteration state.
Vector<SVGTextLayoutAttributes*>& m_layoutAttributes;
+ unsigned m_layoutAttributesPosition;
+ unsigned m_logicalCharacterOffset;
+ unsigned m_logicalMetricsListOffset;
Vector<SVGInlineTextBox*> m_lineLayoutBoxes;
SVGTextFragment m_currentTextFragment;
- unsigned m_layoutAttributesPosition;
- unsigned m_logicalCharacterOffset;
- unsigned m_logicalMetricsListOffset;
SVGInlineTextMetricsIterator m_visualMetricsIterator;
FloatPoint m_textPosition;
bool m_isVerticalText;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698