third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h - Issue 1935493002: Refactor SVGTextLayoutEngine::currentLogicalCharacterMetrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h

Issue 1935493002: Refactor SVGTextLayoutEngine::currentLogicalCharacterMetrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix flow and add some comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h

index cdac5757fdb34d34d0ea7a167e02fecfbf29de03..368551b92dca49a54e16a0bc3aee9c6fcd40c012 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h

@@ -71,19 +71,19 @@ private:

void layoutInlineTextBox(SVGInlineTextBox*);

void layoutTextOnLineOrPath(SVGInlineTextBox*, LineLayoutSVGInlineText, const ComputedStyle&);

- bool currentLogicalCharacterAttributes(SVGTextLayoutAttributes*&);

- bool currentLogicalCharacterMetrics(SVGTextLayoutAttributes*&, SVGTextMetrics&);

+ const SVGTextLayoutAttributes* nextLogicalAttributes();

+ const SVGTextLayoutAttributes* currentLogicalCharacterMetrics(SVGTextMetrics&);

void advanceToNextLogicalCharacter(const SVGTextMetrics&);

-private:

Stephen Chennney 2016/04/29 17:15:28 Why does this get removed?

fs 2016/04/29 17:35:12 Because there's one like it just less than 20 line

+ // Logical iteration state.

Vector<SVGTextLayoutAttributes*>& m_layoutAttributes;

+ unsigned m_layoutAttributesPosition;

+ unsigned m_logicalCharacterOffset;

+ unsigned m_logicalMetricsListOffset;

Vector<SVGInlineTextBox*> m_lineLayoutBoxes;

SVGTextFragment m_currentTextFragment;

- unsigned m_layoutAttributesPosition;

- unsigned m_logicalCharacterOffset;

- unsigned m_logicalMetricsListOffset;

SVGInlineTextMetricsIterator m_visualMetricsIterator;

FloatPoint m_textPosition;

bool m_isVerticalText;