Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1935373002: Revert of Fixed DevTools event-listener breakpoints for PointerEvents. (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
Reviewers:
kozy, mustaq, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixed DevTools event-listener breakpoints for PointerEvents. (patchset #3 id:40001 of https://codereview.chromium.org/1915623002/ ) Reason for revert: Reverting this, one of the tests is timing out in debug builds: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/1480/steps/webkit_tests/logs/stdio Original issue's description: > Fixed DevTools event-listener breakpoints for PointerEvents. > > Also added a test with PointerEvent specific expectation, in > the "pointerevent" virtual suite. > > BUG=605706 > > Committed: https://crrev.com/2ce75f46df1069cd68a30be5a1298f21c7774f60 > Cr-Commit-Position: refs/heads/master@{#390988} TBR=kozyatinskiy@chromium.org,lushnikov@chromium.org,mustaq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605706 Committed: https://crrev.com/9e50c5889bb9034888da15721abc76b211353d7d Cr-Commit-Position: refs/heads/master@{#391113}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
Dirk Pranke
Created Revert of Fixed DevTools event-listener breakpoints for PointerEvents.
4 years, 7 months ago (2016-05-03 00:11:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935373002/1
4 years, 7 months ago (2016-05-03 00:11:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 00:12:22 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9e50c5889bb9034888da15721abc76b211353d7d Cr-Commit-Position: refs/heads/master@{#391113}
4 years, 7 months ago (2016-05-03 00:14:06 UTC) #6
mustaq
4 years, 7 months ago (2016-05-03 14:15:51 UTC) #7
Message was sent while issue was closed.
On 2016/05/03 00:14:06, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/9e50c5889bb9034888da15721abc76b211353d7d
> Cr-Commit-Position: refs/heads/master@{#391113}

LGTM. We knew the timeout issue in Linux (crbug.com/608356) but didn't see Mac
tests failing before, sorry.

Powered by Google App Engine
This is Rietveld 408576698