Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 1935263002: Add more detail to the layout test server cli_wrapper command help. (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more detail to the layout test server cli_wrapper command help. Also in this CL, related minor changes: - Switch from optparse to argparse - Update the module-level docstring BUG=608478 Committed: https://crrev.com/d71f4df61e5fcde12f83f27da9e228b7cf143a66 Cr-Commit-Position: refs/heads/master@{#391611}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper.py View 2 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
qyearsley
Reason for this CL: I wanted `run-blink-wptserve` to print the port numbers it uses, but ...
4 years, 7 months ago (2016-05-02 21:15:04 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-03 23:10:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935263002/1
4 years, 7 months ago (2016-05-03 23:29:57 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
4 years, 7 months ago (2016-05-04 00:33:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935263002/20001
4 years, 7 months ago (2016-05-04 17:59:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 20:05:18 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 20:06:42 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d71f4df61e5fcde12f83f27da9e228b7cf143a66
Cr-Commit-Position: refs/heads/master@{#391611}

Powered by Google App Engine
This is Rietveld 408576698