Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1935233002: 👖 Mark a few build-time-only third-party README.chromiums as NOT_SHIPPED (Closed)

Created:
4 years, 7 months ago by agrieve
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark a few build-time-only third-party README.chromiums as NOT_SHIPPED To avoid them being listed in about:credits BUG=332521 Committed: https://crrev.com/c11f4b9a2e07b096d77ad038d42b83d9203eb0bf Cr-Commit-Position: refs/heads/master@{#391285}

Patch Set 1 #

Patch Set 2 : chromite #

Patch Set 3 : #

Patch Set 4 : revert custom_tabs_client (we intend to compile it in) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M third_party/class-dump/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ijar/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/jmake/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/markdown/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ocmock/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/proguard/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M tools/licenses.py View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
agrieve
justincohen@chromium.org: Please review changes in class-dump/ rockot@chromium.org: Please review changes in markdown/ yusufo@chromium.org: Please review ...
4 years, 7 months ago (2016-05-03 01:08:26 UTC) #2
justincohen
We don't ship class-dump, LGTM.
4 years, 7 months ago (2016-05-03 01:11:01 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-03 01:30:48 UTC) #4
Torne
proguard and license.py changes LGTM, thanks!
4 years, 7 months ago (2016-05-03 12:05:41 UTC) #5
Robert Sesek
ocmock lgtm
4 years, 7 months ago (2016-05-03 13:13:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935233002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935233002/60001
4 years, 7 months ago (2016-05-03 16:54:05 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-03 17:39:02 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 17:40:26 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c11f4b9a2e07b096d77ad038d42b83d9203eb0bf
Cr-Commit-Position: refs/heads/master@{#391285}

Powered by Google App Engine
This is Rietveld 408576698