Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: content/browser/media/android/browser_media_player_manager.cc

Issue 193523002: Encrypted Media: Implement IPC based SetCdm(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase only Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/browser_media_player_manager.cc
diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc
index 40e18250858e3ed47ab9fe1dce604d8f34fb4bd2..24fb708b3deab760995aff0a33665586575c8b2d 100644
--- a/content/browser/media/android/browser_media_player_manager.cc
+++ b/content/browser/media/android/browser_media_player_manager.cc
@@ -149,6 +149,7 @@ bool BrowserMediaPlayerManager::OnMessageReceived(const IPC::Message& msg) {
IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_DestroyMediaPlayer, OnDestroyPlayer)
IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_DestroyAllMediaPlayers,
DestroyAllMediaPlayers)
+ IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_SetCdm, OnSetCdm)
IPC_MESSAGE_HANDLER(CdmHostMsg_InitializeCdm, OnInitializeCdm)
IPC_MESSAGE_HANDLER(CdmHostMsg_CreateSession, OnCreateSession)
IPC_MESSAGE_HANDLER(CdmHostMsg_UpdateSession, OnUpdateSession)
@@ -522,10 +523,14 @@ void BrowserMediaPlayerManager::OnInitialize(
RenderProcessHostImpl* host = static_cast<RenderProcessHostImpl*>(
web_contents()->GetRenderProcessHost());
- AddPlayer(CreateMediaPlayer(
+ MediaPlayerAndroid* player = CreateMediaPlayer(
type, player_id, url, first_party_for_cookies, demuxer_client_id,
host->GetBrowserContext()->IsOffTheRecord(), this,
- host->browser_demuxer_android()));
+ host->browser_demuxer_android());
+ if (!player)
+ return;
+
+ AddPlayer(player);
}
void BrowserMediaPlayerManager::OnStart(int player_id) {
@@ -590,9 +595,6 @@ void BrowserMediaPlayerManager::OnInitializeCdm(int cdm_id,
}
AddDrmBridge(cdm_id, key_system, frame_url);
- // In EME v0.1b MediaKeys lives in the media element. So the |cdm_id|
- // is the same as the |player_id|.
- OnSetMediaKeys(cdm_id, cdm_id);
}
void BrowserMediaPlayerManager::OnCreateSession(
@@ -781,13 +783,14 @@ void BrowserMediaPlayerManager::RemoveDrmBridge(int cdm_id) {
}
}
-void BrowserMediaPlayerManager::OnSetMediaKeys(int player_id, int cdm_id) {
+void BrowserMediaPlayerManager::OnSetCdm(int player_id, int cdm_id) {
MediaPlayerAndroid* player = GetPlayer(player_id);
MediaDrmBridge* drm_bridge = GetDrmBridge(cdm_id);
- if (!player || !drm_bridge) {
- DVLOG(1) << "OnSetMediaKeys(): Player and MediaKeys must be present.";
+ if (!drm_bridge || !player) {
+ DVLOG(1) << "Cannot set CDM on the specified player.";
return;
}
+
// TODO(qinmin): add the logic to decide whether we should create the
// fullscreen surface for EME lv1.
player->SetDrmBridge(drm_bridge);

Powered by Google App Engine
This is Rietveld 408576698