Chromium Code Reviews| Index: content/browser/media/android/browser_media_player_manager.cc |
| diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc |
| index 81f056bd6db0054885e97e1173fbf7d7dc15d597..66f5bf48a85a0315b6fdefd895c8911fbb2d9b3c 100644 |
| --- a/content/browser/media/android/browser_media_player_manager.cc |
| +++ b/content/browser/media/android/browser_media_player_manager.cc |
| @@ -149,6 +149,7 @@ bool BrowserMediaPlayerManager::OnMessageReceived(const IPC::Message& msg) { |
| IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_DestroyMediaPlayer, OnDestroyPlayer) |
| IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_DestroyAllMediaPlayers, |
| DestroyAllMediaPlayers) |
| + IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_SetCdm, OnSetCdm) |
| IPC_MESSAGE_HANDLER(CdmHostMsg_InitializeCdm, OnInitializeCdm) |
| IPC_MESSAGE_HANDLER(CdmHostMsg_CreateSession, OnCreateSession) |
| IPC_MESSAGE_HANDLER(CdmHostMsg_UpdateSession, OnUpdateSession) |
| @@ -520,10 +521,14 @@ void BrowserMediaPlayerManager::OnInitialize( |
| RenderProcessHostImpl* host = static_cast<RenderProcessHostImpl*>( |
| web_contents()->GetRenderProcessHost()); |
| - AddPlayer(CreateMediaPlayer( |
| + MediaPlayerAndroid* player = CreateMediaPlayer( |
| type, player_id, url, first_party_for_cookies, demuxer_client_id, |
| host->GetBrowserContext()->IsOffTheRecord(), this, |
| - host->browser_demuxer_android())); |
| + host->browser_demuxer_android()); |
| + if (!player) |
| + return; |
| + |
| + AddPlayer(player); |
| } |
| void BrowserMediaPlayerManager::OnStart(int player_id) { |
| @@ -588,9 +593,6 @@ void BrowserMediaPlayerManager::OnInitializeCdm(int cdm_id, |
| } |
| AddDrmBridge(cdm_id, key_system, frame_url); |
| - // In EME v0.1b MediaKeys lives in the media element. So the |cdm_id| |
| - // is the same as the |player_id|. |
| - OnSetMediaKeys(cdm_id, cdm_id); |
| } |
| void BrowserMediaPlayerManager::OnCreateSession( |
| @@ -779,13 +781,14 @@ void BrowserMediaPlayerManager::RemoveDrmBridge(int cdm_id) { |
| } |
| } |
| -void BrowserMediaPlayerManager::OnSetMediaKeys(int player_id, int cdm_id) { |
| +void BrowserMediaPlayerManager::OnSetCdm(int player_id, int cdm_id) { |
| MediaPlayerAndroid* player = GetPlayer(player_id); |
| MediaDrmBridge* drm_bridge = GetDrmBridge(cdm_id); |
| - if (!player || !drm_bridge) { |
| - DVLOG(1) << "OnSetMediaKeys(): Player and MediaKeys must be present."; |
| + if (!drm_bridge || !player) { |
| + DVLOG(1) << "MediaDrmBridge and MediaPlayerAndroid must be present!"; |
|
ddorwin
2014/03/25 23:03:59
nit: "present" doesn't seem like the right word.
xhwang
2014/03/26 06:02:04
Done.
|
| return; |
| } |
| + |
| // TODO(qinmin): add the logic to decide whether we should create the |
| // fullscreen surface for EME lv1. |
| player->SetDrmBridge(drm_bridge); |