Encrypted Media: Implement IPC based SetCdm().

content/browser/media/android/browser_media_player_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/android/browser_media_player_manager.h"
 
 #include "base/command_line.h"
 #include "content/browser/android/content_view_core_impl.h"
 #include "content/browser/media/android/browser_demuxer_android.h"
 #include "content/browser/media/android/media_resource_getter_impl.h"
@@ skipping 131 matching lines @@
     IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_Initialize, OnInitialize)
     IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_Start, OnStart)
     IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_Seek, OnSeek)
     IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_Pause, OnPause)
     IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_SetVolume, OnSetVolume)
     IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_SetPoster, OnSetPoster)
     IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_Release, OnReleaseResources)
     IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_DestroyMediaPlayer, OnDestroyPlayer)
     IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_DestroyAllMediaPlayers,
                         DestroyAllMediaPlayers)
+    IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_SetMediaKeys, OnSetMediaKeys)
     IPC_MESSAGE_HANDLER(CdmHostMsg_InitializeCdm, OnInitializeCdm)
     IPC_MESSAGE_HANDLER(CdmHostMsg_CreateSession, OnCreateSession)
     IPC_MESSAGE_HANDLER(CdmHostMsg_UpdateSession, OnUpdateSession)
     IPC_MESSAGE_HANDLER(CdmHostMsg_ReleaseSession, OnReleaseSession)
     IPC_MESSAGE_HANDLER(CdmHostMsg_DestroyCdm, OnDestroyCdm)
 #if defined(VIDEO_HOLE)
     IPC_MESSAGE_HANDLER(MediaPlayerHostMsg_NotifyExternalSurface,
                         OnNotifyExternalSurface)
 #endif  // defined(VIDEO_HOLE)
     IPC_MESSAGE_UNHANDLED(handled = false)
@@ skipping 351 matching lines @@
     const GURL& first_party_for_cookies,
     int demuxer_client_id) {
   DCHECK(type != MEDIA_PLAYER_TYPE_MEDIA_SOURCE || demuxer_client_id > 0)
       << "Media source players must have positive demuxer client IDs: "
       << demuxer_client_id;
 
   RemovePlayer(player_id);
 
   RenderProcessHostImpl* host = static_cast<RenderProcessHostImpl*>(
       web_contents()->GetRenderProcessHost());
-  AddPlayer(CreateMediaPlayer(
+  MediaPlayerAndroid* player = CreateMediaPlayer(
       type, player_id, url, first_party_for_cookies, demuxer_client_id,
       host->GetBrowserContext()->IsOffTheRecord(), this,
-      host->browser_demuxer_android()));
+      host->browser_demuxer_android());
+  if (!player)
+    return;
+
+  AddPlayer(player);
+
+  if (pending_set_media_keys_map_.find(player_id) ==
+      pending_set_media_keys_map_.end()) {
+    return;
+  }
+
+  int cdm_id = pending_set_media_keys_map_[player_id];

[ddorwin, 2014/03/11 04:06:33]

Better to save a temp iterator above?

[xhwang, 2014/03/12 01:07:52]

Obsolete.

+  MediaDrmBridge* drm_bridge = GetDrmBridge(cdm_id);

[ddorwin, 2014/03/11 04:06:33]

Should we erase it from the map? Otherwise, we'll grow indefinitely, right?

[xhwang, 2014/03/12 01:07:52]

You are right. But this code is obsolete now.

+  if (!drm_bridge)

[ddorwin, 2014/03/11 04:06:33]

Should this ever fail?

[xhwang, 2014/03/12 01:07:52]

This code is obsolete. But this is possible. OnInitializeCdm() or
MediaDrmBridge::Create() could fail, in which cases we do nothing. Then when
update() is called, we send a session error back.

+    player->SetDrmBridge(drm_bridge);
 }
 
 void BrowserMediaPlayerManager::OnStart(int player_id) {
   MediaPlayerAndroid* player = GetPlayer(player_id);
   if (player)
     player->Start();
 }
 
 void BrowserMediaPlayerManager::OnSeek(
     int player_id,
@@ skipping 44 matching lines @@
     NOTREACHED() << "Invalid key system: " << key_system;
     return;
   }
 
   if (!MediaDrmBridge::IsKeySystemSupportedWithType(key_system, "")) {
     NOTREACHED() << "Unsupported key system: " << key_system;
     return;
   }
 
   AddDrmBridge(cdm_id, key_system, frame_url);
-  // In EME v0.1b MediaKeys lives in the media element. So the |cdm_id|
-  // is the same as the |player_id|.
-  OnSetMediaKeys(cdm_id, cdm_id);
 }
 
 void BrowserMediaPlayerManager::OnCreateSession(
     int cdm_id,
     uint32 session_id,
     CdmHostMsg_CreateSession_ContentType content_type,
     const std::vector<uint8>& init_data) {
   if (init_data.size() > kMaxInitDataLength) {
     LOG(WARNING) << "InitData for ID: " << cdm_id
                  << " too long: " << init_data.size();
@@ skipping 184 matching lines @@
   for (ScopedVector<MediaDrmBridge>::iterator it = drm_bridges_.begin();
       it != drm_bridges_.end(); ++it) {
     if ((*it)->cdm_id() == cdm_id) {
       drm_bridges_.erase(it);
       break;
     }
   }
 }
 
 void BrowserMediaPlayerManager::OnSetMediaKeys(int player_id, int cdm_id) {
-  MediaPlayerAndroid* player = GetPlayer(player_id);
   MediaDrmBridge* drm_bridge = GetDrmBridge(cdm_id);
-  if (!player || !drm_bridge) {
-    DVLOG(1) << "OnSetMediaKeys(): Player and MediaKeys must be present.";
+  if (!drm_bridge) {
+    DVLOG(1) << "OnSetMediaKeys(): MediaDrmBridge must be present.";
     return;
   }
+
+  MediaPlayerAndroid* player = GetPlayer(player_id);
+  // SetMediaKeys() may be called before the player is loaded.

[ddorwin, 2014/03/11 04:06:33]

How do we know the player_id in that case?

[xhwang, 2014/03/12 01:07:52]

Removed.

+  if (!player) {
+    pending_set_media_keys_map_[player_id] = cdm_id;
+    return;
+  }
+
   // TODO(qinmin): add the logic to decide whether we should create the
   // fullscreen surface for EME lv1.
   player->SetDrmBridge(drm_bridge);
 }
 
 void BrowserMediaPlayerManager::CreateSessionIfPermitted(
     int cdm_id,
     uint32 session_id,
     const std::string& content_type,
     const std::vector<uint8>& init_data,
@@ skipping 70 matching lines @@
   if (player && player->IsSurfaceInUse())
     return;
   ExternalVideoSurfaceContainer* surface_container =
       ExternalVideoSurfaceContainer::FromWebContents(web_contents_);
   if (surface_container)
     surface_container->ReleaseExternalVideoSurface(player_id);
 #endif  // defined(VIDEO_HOLE)
 }
 
 }  // namespace content