courgette/disassembler_elf_32_x86.h - Issue 1935203002: [Courgette] Using LabelManager to reduce Courgette-apply peak RAM by 25%.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/disassembler_elf_32_x86.h

Issue 1935203002: [Courgette] Using LabelManager to reduce Courgette-apply peak RAM by 25%. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: courgette/disassembler_elf_32_x86.h

diff --git a/courgette/disassembler_elf_32_x86.h b/courgette/disassembler_elf_32_x86.h

index 63be75544f3a5b203171dd103c1978890c102b8f..706e6fee33b101e354727ab037ee90942613d43f 100644

--- a/courgette/disassembler_elf_32_x86.h

+++ b/courgette/disassembler_elf_32_x86.h

@@ -28,7 +28,7 @@ class DisassemblerElf32X86 : public DisassemblerElf32 {

// TypedRVA interfaces.

CheckBool ComputeRelativeTarget(const uint8_t* op_pointer) override;

CheckBool EmitInstruction(AssemblyProgram* program,

- RVA target_rva) override;

+ Label* label) override;

uint16_t op_size() const override;

};

« no previous file with comments | « courgette/disassembler_elf_32_arm.cc ('k') | courgette/disassembler_elf_32_x86.cc » ('j') | no next file with comments »