courgette/disassembler_elf_32_x86.cc - Issue 1935203002: [Courgette] Using LabelManager to reduce Courgette-apply peak RAM by 25%.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/disassembler_elf_32_x86.cc

Issue 1935203002: [Courgette] Using LabelManager to reduce Courgette-apply peak RAM by 25%. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: courgette/disassembler_elf_32_x86.cc

diff --git a/courgette/disassembler_elf_32_x86.cc b/courgette/disassembler_elf_32_x86.cc

index f73371c2cef276ecc0cc8f8b04314c58f526f5d3..23b3991a9f26f5b54928e941bc31e38d48ac9907 100644

--- a/courgette/disassembler_elf_32_x86.cc

+++ b/courgette/disassembler_elf_32_x86.cc

@@ -21,8 +21,8 @@ CheckBool DisassemblerElf32X86::TypedRVAX86::ComputeRelativeTarget(

CheckBool DisassemblerElf32X86::TypedRVAX86::EmitInstruction(

AssemblyProgram* program,

- RVA target_rva) {

- return program->EmitRel32(program->FindOrMakeRel32Label(target_rva));

+ Label* label) {

+ return program->EmitRel32(label);

}

uint16_t DisassemblerElf32X86::TypedRVAX86::op_size() const {

« courgette/courgette.h ('K') | « courgette/disassembler_elf_32_x86.h ('k') | courgette/disassembler_win32_x64.h » ('j') | courgette/disassembler_win32_x86.cc » ('J')