Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1935173002: Reject calcs with both lengths and percentages in radial-gradient (Closed)

Created:
4 years, 7 months ago by rwlbuis
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reject calcs with both lengths and percentages in radial-gradient Reject calcs with both lengths and percentages in radial-gradient, while for ellipse both length and percentage are allowed, they are not allowed at the same time [1]. [1] https://drafts.csswg.org/css-images-3/#radial-gradients Committed: https://crrev.com/6922fc90544b2e2db3f959be00b4bf0fdaaf2a6f Cr-Commit-Position: refs/heads/master@{#398068}

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : Add separate test #

Patch Set 4 : Add more subtests #

Total comments: 4

Patch Set 5 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css/radial-gradient-calc-percentage-pixels.html View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
rwlbuis
PTAL.
4 years, 6 months ago (2016-06-03 22:32:09 UTC) #3
Timothy Loh
lgtm https://codereview.chromium.org/1935173002/diff/60001/third_party/WebKit/LayoutTests/fast/css/radial-gradient-calc-percentage-pixels.html File third_party/WebKit/LayoutTests/fast/css/radial-gradient-calc-percentage-pixels.html (right): https://codereview.chromium.org/1935173002/diff/60001/third_party/WebKit/LayoutTests/fast/css/radial-gradient-calc-percentage-pixels.html#newcode1 third_party/WebKit/LayoutTests/fast/css/radial-gradient-calc-percentage-pixels.html:1: <script src="../../resources/testharness.js"></script> <!doctype html> https://codereview.chromium.org/1935173002/diff/60001/third_party/WebKit/LayoutTests/fast/css/radial-gradient-calc-percentage-pixels.html#newcode7 third_party/WebKit/LayoutTests/fast/css/radial-gradient-calc-percentage-pixels.html:7: assert_false(CSS.supports('background', 'radial-gradient(calc(60% ...
4 years, 6 months ago (2016-06-06 04:10:25 UTC) #4
rwlbuis
https://codereview.chromium.org/1935173002/diff/60001/third_party/WebKit/LayoutTests/fast/css/radial-gradient-calc-percentage-pixels.html File third_party/WebKit/LayoutTests/fast/css/radial-gradient-calc-percentage-pixels.html (right): https://codereview.chromium.org/1935173002/diff/60001/third_party/WebKit/LayoutTests/fast/css/radial-gradient-calc-percentage-pixels.html#newcode1 third_party/WebKit/LayoutTests/fast/css/radial-gradient-calc-percentage-pixels.html:1: <script src="../../resources/testharness.js"></script> On 2016/06/06 04:10:25, Timothy Loh wrote: > ...
4 years, 6 months ago (2016-06-06 16:45:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935173002/80001
4 years, 6 months ago (2016-06-06 16:46:20 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-06 18:21:45 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 18:23:50 UTC) #12
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/6922fc90544b2e2db3f959be00b4bf0fdaaf2a6f
Cr-Commit-Position: refs/heads/master@{#398068}

Powered by Google App Engine
This is Rietveld 408576698