Make sure that Vulkan debug callback ptr is non-null.

Make sure that Vulkan debug callback ptr is non-null.

BUG=skia:5244
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1935163002

Committed: https://skia.googlesource.com/skia/+/a00980e58037fa36d066be80d7fcc0f73b2dfd40

[jvanverth1, 2016-05-02 18:20:05]

Description was changed from

==========
Make sure that Vulkan debug callback ptr is non-null.

BUG=skia:5244
==========

to

==========
Make sure that Vulkan debug callback ptr is non-null.

BUG=skia:5244
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2016-05-02 18:21:54]

jvanverth@google.com changed reviewers:
+ djsollen@google.com, liyuqian@google.com

[jvanverth1, 2016-05-02 18:21:54]

I don't have a working Android setup at the moment, but I think this might be
the problem. PTAL.

[djsollen, 2016-05-02 18:45:25]

yuquian, can you patch in this CL and verify?

[liyuqian, 2016-05-02 18:57:27]

On 2016/05/02 18:45:25, djsollen wrote:
> yuquian, can you patch in this CL and verify?

Bug is fixed.

[djsollen, 2016-05-02 19:17:44]

looks good other than your editor seemed to inject tabs instead of spaces.

https://codereview.chromium.org/1935163002/diff/1/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/1935163002/diff/1/src/gpu/vk/GrVkGpu.cpp#newc...
src/gpu/vk/GrVkGpu.cpp:137: fCurrentCmdBuffer->end(this);
spaces not tabs.

https://codereview.chromium.org/1935163002/diff/1/src/gpu/vk/GrVkGpu.h
File src/gpu/vk/GrVkGpu.h (right):

https://codereview.chromium.org/1935163002/diff/1/src/gpu/vk/GrVkGpu.h#newcod...
src/gpu/vk/GrVkGpu.h:222: VkDebugReportCallbackEXT               fCallback;
spaces not tabs.

[jvanverth1, 2016-05-02 19:44:59]

On 2016/05/02 19:17:44, djsollen wrote:
> looks good other than your editor seemed to inject tabs instead of spaces.
> 
> https://codereview.chromium.org/1935163002/diff/1/src/gpu/vk/GrVkGpu.cpp
> File src/gpu/vk/GrVkGpu.cpp (right):
> 
>
https://codereview.chromium.org/1935163002/diff/1/src/gpu/vk/GrVkGpu.cpp#newc...
> src/gpu/vk/GrVkGpu.cpp:137: fCurrentCmdBuffer->end(this);
> spaces not tabs.
> 
> https://codereview.chromium.org/1935163002/diff/1/src/gpu/vk/GrVkGpu.h
> File src/gpu/vk/GrVkGpu.h (right):
> 
>
https://codereview.chromium.org/1935163002/diff/1/src/gpu/vk/GrVkGpu.h#newcod...
> src/gpu/vk/GrVkGpu.h:222: VkDebugReportCallbackEXT               fCallback;
> spaces not tabs.

Curse you, new VS 2015 installation.

[jvanverth1, 2016-05-02 19:56:33]

https://codereview.chromium.org/1935163002/diff/1/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/1935163002/diff/1/src/gpu/vk/GrVkGpu.cpp#newc...
src/gpu/vk/GrVkGpu.cpp:137: fCurrentCmdBuffer->end(this);
On 2016/05/02 19:17:44, djsollen wrote:
> spaces not tabs.

Done.

https://codereview.chromium.org/1935163002/diff/1/src/gpu/vk/GrVkGpu.h
File src/gpu/vk/GrVkGpu.h (right):

https://codereview.chromium.org/1935163002/diff/1/src/gpu/vk/GrVkGpu.h#newcod...
src/gpu/vk/GrVkGpu.h:222: VkDebugReportCallbackEXT               fCallback;
On 2016/05/02 19:17:44, djsollen wrote:
> spaces not tabs.

Done.

[djsollen, 2016-05-02 19:58:36]

The CQ bit was checked by djsollen@google.com

[djsollen, 2016-05-02 19:58:36]

lgtm

[commit-bot: I haz the power, 2016-05-02 19:58:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935163002/40001

[commit-bot: I haz the power, 2016-05-02 20:24:51]

Description was changed from

==========
Make sure that Vulkan debug callback ptr is non-null.

BUG=skia:5244
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make sure that Vulkan debug callback ptr is non-null.

BUG=skia:5244
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a00980e58037fa36d066be80d7fcc0f73b2dfd40
==========

[commit-bot: I haz the power, 2016-05-02 20:24:52]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a00980e58037fa36d066be80d7fcc0f73b2dfd40