Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 193513002: Return error object from Dart_Allocate when an error occurs. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc (revision 33504)
+++ runtime/vm/dart_api_impl.cc (working copy)
@@ -3139,7 +3139,9 @@
if (type_obj.IsNull()) {
RETURN_TYPE_ERROR(isolate, type, Type);
}
- const Class& cls = Class::Handle(isolate, type_obj.type_class());
+ REUSABLE_CLASS_HANDLESCOPE(isolate);
+ Class& cls = isolate->ClassHandle();
+ cls = type_obj.type_class();
if (!cls.is_fields_marked_nullable()) {
// Mark all fields as nullable.
@@ -3160,6 +3162,13 @@
}
}
+ REUSABLE_ERROR_HANDLESCOPE(isolate);
+ Error& error = isolate->ErrorHandle();
+ error = cls.EnsureIsFinalized(isolate);
+ if (!error.IsNull()) {
+ // An error occurred, return error object.
+ return Api::NewHandle(isolate, error.raw());
+ }
// Allocate an object for the given class.
return Api::NewHandle(isolate, Instance::New(cls));
}
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698