Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1935123002: Remove swappedout: scheme since it is not used anymore. (Closed)

Created:
4 years, 7 months ago by nasko
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, msramek+watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, markusheintz_, siteadmin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove swappedout: scheme since it is not used anymore. BUG=357747 Committed: https://crrev.com/22137d9f14b230b45d4876865a1c9ca16b9c47b7 Cr-Commit-Position: refs/heads/master@{#391058}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/browser/browsing_data/browsing_data_helper_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/url_constants.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/url_constants.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
nasko
Hey Charlie, Can you review one more remnant of swapped out going away? Thanks in ...
4 years, 7 months ago (2016-05-02 18:03:14 UTC) #2
nasko
Adding thestig@ for chrome/ OWNERs review.
4 years, 7 months ago (2016-05-02 18:04:40 UTC) #4
Charlie Reis
Nice! LGTM.
4 years, 7 months ago (2016-05-02 18:06:07 UTC) #5
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-02 18:24:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935123002/1
4 years, 7 months ago (2016-05-02 20:11:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/176185)
4 years, 7 months ago (2016-05-02 20:18:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935123002/20001
4 years, 7 months ago (2016-05-02 20:26:50 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 21:36:58 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 21:38:39 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/22137d9f14b230b45d4876865a1c9ca16b9c47b7
Cr-Commit-Position: refs/heads/master@{#391058}

Powered by Google App Engine
This is Rietveld 408576698