extensions/shell/browser/shell_screen.cc - Issue 1935083003: gfx::Screen: Replace GetWindowUnderCursor() with IsWindowUnderCursor().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_screen.cc

Issue 1935083003: gfx::Screen: Replace GetWindowUnderCursor() with IsWindowUnderCursor(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Null checks Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/shell/browser/shell_screen.cc

diff --git a/extensions/shell/browser/shell_screen.cc b/extensions/shell/browser/shell_screen.cc

index 4b103bed87b6ab24ebf5df45d461cb95cda462e6..157750871cc0da29202df01f27b197327e5555dc 100644

--- a/extensions/shell/browser/shell_screen.cc

+++ b/extensions/shell/browser/shell_screen.cc

@@ -63,8 +63,8 @@ gfx::Point ShellScreen::GetCursorScreenPoint() {

return aura::Env::GetInstance()->last_mouse_location();

}

-gfx::NativeWindow ShellScreen::GetWindowUnderCursor() {

- return GetWindowAtScreenPoint(GetCursorScreenPoint());

+bool ShellScreen::IsWindowUnderCursor(gfx::NativeWindow window) {

+ return GetWindowAtScreenPoint(GetCursorScreenPoint()) == window;

}

gfx::NativeWindow ShellScreen::GetWindowAtScreenPoint(const gfx::Point& point) {

« no previous file with comments | « extensions/shell/browser/shell_screen.h ('k') | headless/lib/browser/headless_screen.h » ('j') | ui/views/mus/screen_mus.cc » ('J')