Issue 1934993003: Use <(DEPTH) instead of fixed relative path to avoid issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1934993003: Use <(DEPTH) instead of fixed relative path to avoid issues

Created:
4 years, 7 months ago by Alexander Potapenko

Modified:
4 years, 7 months ago

Reviewers:
aizatsky, eugenis, Yang, Michael Achenbach

Base URL:
https://chromium.googlesource.com/chromium/buildtools.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use <(DEPTH) instead of fixed relative path to avoid issues with buildtools/third_party/libc++ being located in a place different from the project root (this is what happens in v8) BUG=607107

Patch Set 1 #

Patch Set 2 : update #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/libc++/libc++.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

4 years, 7 months ago (2016-05-02 17:49:57 UTC) #4

Reuploaded as https://codereview.chromium.org/1940983002/ to run the trybots.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages