Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1934973002: [turbofan] Extend the type fixup to LoadField as well. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Extend the type fixup to LoadField as well. For LoadElimination we must not replace LoadField nodes with other nodes whose types are not a subtype of the original LoadField type, as that breaks the verifier. We already fixed that earlier for store to load forwarding, but the fix didn't cover LoadField forwarding. This actually still generates the correct code even w/o the fix, but since recently fails due to stronger checking in representation selection. So this makes clusterfuzz happy again. R=mvstanton@chromium.org BUG=chromium:607899 LOG=n Committed: https://crrev.com/c0e65ea85d09780a13685ff06a83b38cef0b279a Cr-Commit-Position: refs/heads/master@{#35930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/load-elimination.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-02 11:00:35 UTC) #1
mvstanton
lgtm
4 years, 7 months ago (2016-05-02 11:01:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934973002/1
4 years, 7 months ago (2016-05-02 11:02:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 11:28:50 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 11:30:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0e65ea85d09780a13685ff06a83b38cef0b279a
Cr-Commit-Position: refs/heads/master@{#35930}

Powered by Google App Engine
This is Rietveld 408576698