Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 193493005: Windows PIII (non-SSE2) deprecation infobar (Closed)

Created:
6 years, 9 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews
Visibility:
Public.

Description

Windows PIII (non-SSE2) deprecation infobar Chrome 35 will build with SSE2 as the compiler blend. So we need to show the deprecation infobar for Chrome 34 users which don't have SSE2. This is the same infobar we show for Mac 32 bit users. BUG=349320 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cpu_(ooo_6.6-7.5)
ptal. The strings are here: https://codereview.chromium.org/193493002/
6 years, 9 months ago (2014-03-11 03:07:57 UTC) #1
msw
lgtm, presuming the plan was okay'ed by leads. This is pretty heavy, I hope it ...
6 years, 9 months ago (2014-03-11 18:09:49 UTC) #2
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 9 months ago (2014-03-11 22:54:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/193493005/1
6 years, 9 months ago (2014-03-11 23:03:00 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 09:56:52 UTC) #5
Message was sent while issue was closed.
Change committed as 256498

Powered by Google App Engine
This is Rietveld 408576698