Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1934913002: Convert track-load* tests to testharness.js (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert track-load* tests to testharness.js Cleaning up track-load* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/89e7f21d3966d0365824927cc330a7cbf6d752b4 Cr-Commit-Position: refs/heads/master@{#391801}

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments #

Messages

Total messages: 12 (6 generated)
Srirama
PTAL
4 years, 7 months ago (2016-05-01 11:53:48 UTC) #3
mlamouri (slow - plz ping)
lgtm with <script src='media-file.js'> removed if it is actually not needed. https://codereview.chromium.org/1934913002/diff/1/third_party/WebKit/LayoutTests/media/track/track-load-error-readyState.html File third_party/WebKit/LayoutTests/media/track/track-load-error-readyState.html (right): ...
4 years, 7 months ago (2016-05-05 13:20:22 UTC) #4
Srirama
https://codereview.chromium.org/1934913002/diff/1/third_party/WebKit/LayoutTests/media/track/track-load-error-readyState.html File third_party/WebKit/LayoutTests/media/track/track-load-error-readyState.html (right): https://codereview.chromium.org/1934913002/diff/1/third_party/WebKit/LayoutTests/media/track/track-load-error-readyState.html#newcode6 third_party/WebKit/LayoutTests/media/track/track-load-error-readyState.html:6: <script src="../media-file.js"></script> On 2016/05/05 13:20:22, Mounir Lamouri wrote: > ...
4 years, 7 months ago (2016-05-05 13:41:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934913002/20001
4 years, 7 months ago (2016-05-05 13:42:08 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-05 14:40:28 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 14:41:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89e7f21d3966d0365824927cc330a7cbf6d752b4
Cr-Commit-Position: refs/heads/master@{#391801}

Powered by Google App Engine
This is Rietveld 408576698