Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1934883002: Refactor unittests (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor unittests Move serialization tests into subfolder Move data files into data subfolders Move tests with errors/warnings into quarantined subfolder Skip packages/ folder in test The latter three improves workflow in IntelliJ; providing error/warning free analysis of unittests (by exclusion of folders). R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/0e537d80864bb2bd1705dd5d74e1f7bc199d8630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3713 lines) Patch
M tests/compiler/dart2js/analyze_test_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
D tests/compiler/dart2js/dart2js_batch2_run.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/dart2js_batch2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/compiler/dart2js/data/dart2js_batch2_run.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/compiler/dart2js/data/exit_code_helper.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/compiler/dart2js/data/mirrors_helper.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/compiler/dart2js/data/one_line_dart_program.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/compiler/dart2js/exit_code_helper.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/compiler/dart2js/http_test.dart View 1 chunk +0 lines, -181 lines 0 comments Download
D tests/compiler/dart2js/mirrors_helper.dart View 1 chunk +0 lines, -78 lines 0 comments Download
D tests/compiler/dart2js/mirrors_test.dart View 1 chunk +0 lines, -974 lines 0 comments Download
D tests/compiler/dart2js/one_line_dart_program.dart View 1 chunk +0 lines, -1 line 0 comments Download
A + tests/compiler/dart2js/quarantined/http_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + tests/compiler/dart2js/quarantined/mirrors_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + tests/compiler/dart2js/serialization/analysis_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + tests/compiler/dart2js/serialization/compilation_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + tests/compiler/dart2js/serialization/equivalence_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + tests/compiler/dart2js/serialization/helper.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/compiler/dart2js/serialization/impact_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + tests/compiler/dart2js/serialization/library_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + tests/compiler/dart2js/serialization/model_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + tests/compiler/dart2js/serialization/resolved_ast_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + tests/compiler/dart2js/serialization/test_data.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/compiler/dart2js/serialization/test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/compiler/dart2js/serialization_analysis_test.dart View 1 chunk +0 lines, -58 lines 0 comments Download
D tests/compiler/dart2js/serialization_compilation_test.dart View 1 chunk +0 lines, -64 lines 0 comments Download
D tests/compiler/dart2js/serialization_helper.dart View 1 chunk +0 lines, -349 lines 0 comments Download
D tests/compiler/dart2js/serialization_impact_test.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D tests/compiler/dart2js/serialization_library_test.dart View 1 chunk +0 lines, -130 lines 0 comments Download
D tests/compiler/dart2js/serialization_model_test.dart View 1 chunk +0 lines, -194 lines 0 comments Download
D tests/compiler/dart2js/serialization_resolved_ast_test.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D tests/compiler/dart2js/serialization_test.dart View 1 chunk +0 lines, -704 lines 0 comments Download
D tests/compiler/dart2js/serialization_test_data.dart View 1 chunk +0 lines, -218 lines 0 comments Download
D tests/compiler/dart2js/serialization_test_helper.dart View 1 chunk +0 lines, -382 lines 0 comments Download
A + tests/compiler/dart2js/sourcemaps/data/invokes_test_file.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/compiler/dart2js/sourcemaps/data/operators_test_file.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/compiler/dart2js/sourcemaps/invokes_test_file.dart View 1 chunk +0 lines, -127 lines 0 comments Download
D tests/compiler/dart2js/sourcemaps/operators_test_file.dart View 1 chunk +0 lines, -60 lines 0 comments Download
M tests/compiler/dart2js/zero_termination_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-04-30 12:30:53 UTC) #2
Siggi Cherem (dart-lang)
lgtm thank you. Eventually, we should move these tests to pkg/compiler/test/. That will make IDEs ...
4 years, 7 months ago (2016-05-02 17:07:19 UTC) #3
Johnni Winther
4 years, 7 months ago (2016-05-03 08:44:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e537d80864bb2bd1705dd5d74e1f7bc199d8630 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698