Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 1934833002: Ensure filter and reflection outsets are applied on paint invalidation rect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index f1f26471f33d4eab5c6e9dcd5a0c5bce22aa2edd..14e06643001976985b4facba3679160a7a243d33 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -535,9 +535,6 @@ bool ComputedStyle::diffNeedsFullLayoutAndPaintInvalidation(const ComputedStyle&
&& *rareNonInheritedData->m_flexibleBox.get() != *other.rareNonInheritedData->m_flexibleBox.get())
return true;
- if (!rareNonInheritedData->reflectionDataEquivalent(*other.rareNonInheritedData.get()))
- return true;
-
if (rareNonInheritedData->m_multiCol.get() != other.rareNonInheritedData->m_multiCol.get()
&& *rareNonInheritedData->m_multiCol.get() != *other.rareNonInheritedData->m_multiCol.get())
return true;
@@ -698,6 +695,9 @@ bool ComputedStyle::diffNeedsFullLayout(const ComputedStyle& other) const
|| rareNonInheritedData->m_justifyItems != other.rareNonInheritedData->m_justifyItems
|| rareNonInheritedData->m_justifySelf != other.rareNonInheritedData->m_justifySelf)
return true;
+
+ if (!RuntimeEnabledFeatures::cssBoxReflectFilterEnabled() && !rareNonInheritedData->reflectionDataEquivalent(*other.rareNonInheritedData.get()))
+ return true;
}
return false;
@@ -716,6 +716,9 @@ bool ComputedStyle::diffNeedsPaintInvalidationLayer(const ComputedStyle& other)
if (rareNonInheritedData->m_mask != other.rareNonInheritedData->m_mask
|| rareNonInheritedData->m_maskBoxImage != other.rareNonInheritedData->m_maskBoxImage)
return true;
+
+ if (!RuntimeEnabledFeatures::cssBoxReflectFilterEnabled() && !rareNonInheritedData->reflectionDataEquivalent(*other.rareNonInheritedData.get()))
+ return true;
}
return false;
@@ -784,7 +787,7 @@ void ComputedStyle::updatePropertySpecificDifferences(const ComputedStyle& other
if (rareNonInheritedData->m_backdropFilter != other.rareNonInheritedData->m_backdropFilter)
diff.setBackdropFilterChanged();
- if (RuntimeEnabledFeatures::cssBoxReflectFilterEnabled() && rareNonInheritedData->m_boxReflect != other.rareNonInheritedData->m_boxReflect)
+ if (RuntimeEnabledFeatures::cssBoxReflectFilterEnabled() && !rareNonInheritedData->reflectionDataEquivalent(*other.rareNonInheritedData.get()))
diff.setFilterChanged();
}

Powered by Google App Engine
This is Rietveld 408576698