Implementing client policy and controller.

components/offline_pages/client_policy_controller_unittest.cc

Index: components/offline_pages/client_policy_controller_unittest.cc
diff --git a/components/offline_pages/client_policy_controller_unittest.cc b/components/offline_pages/client_policy_controller_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0cdba341098530e18a6c5c17a961e81ca1e7a431
--- /dev/null
+++ b/components/offline_pages/client_policy_controller_unittest.cc
@@ -0,0 +1,53 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/offline_pages/client_policy_controller.h"
+
+#include "base/bind.h"
+#include "base/time/time.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;
+
+namespace offline_pages {
+
+namespace {
+const char kBookmarkNamespace[] = "bookmark";
+const char kLastNNamespace[] = "last_n";
+const char kUndefinedNamespace[] = "undefined";
+const OfflinePageClientPolicy kExpectedBookmarkPolicy = {
+    "bookmark",
+    {LifetimeType::TEMPORARY, base::TimeDelta::FromDays(7), kUnlimitedPages}};
+
+bool isTemporary(const OfflinePageClientPolicy& policy) {

[fgorski, 2016/05/02 23:10:32]

did you consider putting this on OfflinePageClientPolicy as an instance method?

[romax, 2016/05/03 00:29:24]

no... I dont think it's useful to be a method in the class... since the enum in
the ClientPolicy.LifetimePolicy would tell if it's a temporary one. But if
you're referring to a validation method, it would be useful. However it wouldn't
be necessary until we remove the hand written policies.

+  // Check if policy has a expire period > 0 or a limited number
+  // of pages allowed.
+  return (policy.lifetime_policy.page_limit > kUnlimitedPages ||
+          !policy.lifetime_policy.expire_period.is_zero());
+}
+
+}  // namespace
+
+TEST(ClientPolicyControllerTest, FallbackTest) {
+  OfflinePageClientPolicy policy =
+      ClientPolicyController::GetInstance()->GetPolicy(kUndefinedNamespace);
+  EXPECT_EQ(policy.name_space, kDefaultPolicy);
+  EXPECT_TRUE(isTemporary(policy));
+}
+
+TEST(ClientPolicyControllerTest, GetPredefinedPolicy) {
+  OfflinePageClientPolicy policy =
+      ClientPolicyController::GetInstance()->GetPolicy(kBookmarkNamespace);
+  EXPECT_EQ(policy.name_space, "bookmark");
+  EXPECT_TRUE(isTemporary(policy));
+}
+
+TEST(ClientPolicyControllerTest, CheckLastNDefined) {
+  OfflinePageClientPolicy policy =
+      ClientPolicyController::GetInstance()->GetPolicy(kLastNNamespace);
+  EXPECT_EQ(policy.name_space, "last_n");
+  EXPECT_TRUE(isTemporary(policy));
+}
+
+}  // namespace offline_pages