components/offline_pages/client_policies.h - Issue 1934743003: Implementing client policy and controller.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/client_policies.h

Issue 1934743003: Implementing client policy and controller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #undef kUnlimitedPages

	6 #define kUnlimitedPages 0

	7

	8 /**

	9 * This macro is used to define client policies.

	10 * For some details please see offline_page_client_policy.h

	11 *

	12 * Use Example:

	13 * POLICY(name_space, // The name_space of this policy.

	14 * type, // TEMPORARY/PERSISTENT, defined in LifetimePolicy

	15 * expire_days, // Number of days before expire of pages, in days.

	16 * page_limit, // As defined in client policy. Use kUnlimitedPages

	17 * // for unlimited number.

	18 */

	19

	20 #undef CLIENT_POLICIES

	21 #define CLIENT_POLICIES \
	fgorski 2016/05/02 23:10:31 no let's have a static method instead of a macro f no let's have a static method instead of a macro for this. romax 2016/05/03 00:29:24 Done. Show quoted text On 2016/05/02 23:10:31, fgorski wrote: > no let's have a static method instead of a macro for this. Done.
	22 POLICY(bookmark, TEMPORARY, 7, kUnlimitedPages) \

	23 POLICY(last_n, TEMPORARY, 2, 20) \

	24 POLICY(defaultPolicy, TEMPORARY, 1, kUnlimitedPages)

	25

	26 #undef kUnlimitedPages

OLD	NEW