Don’t cache constants in initializer expressions

Don’t cache constants in initializer expressions

Initializer expressions are evaluated only once. Therefore, do not store
constant expressions in the constant cache, since they will never be
used again.

Except: when generating a stack trace and accessing the local variables
in a the stack frame of an initializer expression (static final getter function),
the constant will have to be recomputed instead of retrieved from the cache.
This CL also disables the stacktrace_every stress flag while a stack trace
is being collected, to avoid recursive requests for stack traces.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/6cb7d87e56baa33e97492f1b076dd96466fbfdbb

[hausner, 2016-04-29 20:17:39]

Description was changed from

==========
Don’t cache constants in initializer expressions

Initializer expressions are evaluated only once. Therefore, do not store
constant expressions in the constant cache, since they will never be
used again.

Except: when generating a stack trace and accessing the local variables
in a the stack frame of an initializer expression (static final getter
function),
the constant will have to be recomputed instead of retrieved from the cache.
This CL also disables the stacktrace_every stress flag while a stack trace
is being collected, to avoid recursive requests for stack traces.

BUG=
==========

to

==========
Don’t cache constants in initializer expressions

Initializer expressions are evaluated only once. Therefore, do not store
constant expressions in the constant cache, since they will never be
used again.

Except: when generating a stack trace and accessing the local variables
in a the stack frame of an initializer expression (static final getter
function),
the constant will have to be recomputed instead of retrieved from the cache.
This CL also disables the stacktrace_every stress flag while a stack trace
is being collected, to avoid recursive requests for stack traces.

BUG=
==========

[hausner, 2016-04-29 20:17:39]

hausner@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-04-29 21:01:21]

lgtm

https://codereview.chromium.org/1934733002/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/1934733002/diff/1/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:1291: intptr_t saved_stacktrace_very =
FLAG_stacktrace_every;
saved_stacktrace_every

[hausner, 2016-04-29 22:06:33]

Description was changed from

==========
Don’t cache constants in initializer expressions

Initializer expressions are evaluated only once. Therefore, do not store
constant expressions in the constant cache, since they will never be
used again.

Except: when generating a stack trace and accessing the local variables
in a the stack frame of an initializer expression (static final getter
function),
the constant will have to be recomputed instead of retrieved from the cache.
This CL also disables the stacktrace_every stress flag while a stack trace
is being collected, to avoid recursive requests for stack traces.

BUG=
==========

to

==========
Don’t cache constants in initializer expressions

Initializer expressions are evaluated only once. Therefore, do not store
constant expressions in the constant cache, since they will never be
used again.

Except: when generating a stack trace and accessing the local variables
in a the stack frame of an initializer expression (static final getter
function),
the constant will have to be recomputed instead of retrieved from the cache.
This CL also disables the stacktrace_every stress flag while a stack trace
is being collected, to avoid recursive requests for stack traces.

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6cb7d87e56baa33e97492f1b076dd96466fbfdbb
==========

[hausner, 2016-04-29 22:06:34]

Committed patchset #2 (id:20001) manually as
6cb7d87e56baa33e97492f1b076dd96466fbfdbb (presubmit successful).

[hausner, 2016-04-29 22:11:21]

https://codereview.chromium.org/1934733002/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/1934733002/diff/1/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:1291: intptr_t saved_stacktrace_very =
FLAG_stacktrace_every;
On 2016/04/29 21:01:21, rmacnak wrote:
> saved_stacktrace_every

:-) Thanks