Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.h

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nasko@ comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_guest.h
diff --git a/content/browser/frame_host/render_widget_host_view_guest.h b/content/browser/frame_host/render_widget_host_view_guest.h
index 4c5a6ee5b984672eccbe50d516788a65fe616758..338b637d35678e0b1f920d962cc484a013edc3ae 100644
--- a/content/browser/frame_host/render_widget_host_view_guest.h
+++ b/content/browser/frame_host/render_widget_host_view_guest.h
@@ -98,6 +98,8 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest
void ProcessAckedTouchEvent(const TouchEventWithLatencyInfo& touch,
InputEventAckState ack_result) override;
#endif
+ void ProcessMouseEvent(const blink::WebMouseEvent& event,
+ const ui::LatencyInfo& latency) override;
void ProcessTouchEvent(const blink::WebTouchEvent& event,
const ui::LatencyInfo& latency) override;
@@ -130,6 +132,16 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest
private:
RenderWidgetHostViewBase* GetOwnerRenderWidgetHostView() const;
+ // Since we now route GestureEvents directly to the guest renderer, we need
+ // a way to make sure that the BrowserPlugin in the embedder gets focused so
+ // that keyboard input (which still travels via BrowserPlugin) is routed to
+ // the plugin and thus onwards to the guest.
+ // TODO(wjmaclean): When we remove BrowserPlugin, delete this code.
+ // http://crbug.com/533069
+ void MaybeSendSyntheticTapGesture(
+ const blink::WebFloatPoint& position,
+ const blink::WebFloatPoint& screenPosition) const;
+
void OnHandleInputEvent(RenderWidgetHostImpl* embedder,
int browser_plugin_instance_id,
const blink::WebInputEvent* event);
« no previous file with comments | « content/browser/frame_host/render_frame_proxy_host.cc ('k') | content/browser/frame_host/render_widget_host_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698