Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: content/browser/frame_host/frame_tree.cc

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nasko@ comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/frame_tree.cc
diff --git a/content/browser/frame_host/frame_tree.cc b/content/browser/frame_host/frame_tree.cc
index 4dcf54140956a2165fbd03bba4f3a24a52f38584..300075f79e4e3835c6f63d65447355b5809c4c34 100644
--- a/content/browser/frame_host/frame_tree.cc
+++ b/content/browser/frame_host/frame_tree.cc
@@ -253,6 +253,19 @@ void FrameTree::SetFocusedFrame(FrameTreeNode* node, SiteInstance* source) {
if (node == GetFocusedFrame())
return;
+ if (!node) {
+ // TODO(avallee): https://crbug.com/614463 Notify proxies here once
+ // <webview> supports oopifs inside itself.
+ if (GetFocusedFrame())
+ GetFocusedFrame()->current_frame_host()->ClearFocusedFrame();
+ focused_frame_tree_node_id_ = FrameTreeNode::kFrameTreeNodeInvalidId;
+
+ // TODO(avallee): https://crbug.com/610795 This line is not sufficient to
+ // make the test pass. There seems to be no focus change events generated.
+ root()->current_frame_host()->UpdateAXTreeData();
+ return;
+ }
+
std::set<SiteInstance*> frame_tree_site_instances =
CollectSiteInstances(this);

Powered by Google App Engine
This is Rietveld 408576698