Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nasko@ comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index 6d5b41082168503499c5397cd4445bb285c05cce..61822ac13f9b129870fa81e056f19ab7911f1321 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -869,11 +869,12 @@ INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewVisibilityTest, testing::Bool());
class WebViewSpeechAPITest : public WebViewTest {};
INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSpeechAPITest, testing::Bool());
-// The following test suits are created to group tests based on specific
+// The following test suites are created to group tests based on specific
// features of <webview>.
-// These features current would not work with
+// These features currently would not work with
// --use-cross-process-frames-for-guest and is disabled on
// UseCrossProcessFramesForGuests.
+// TODO(avallee): https://crbug.com/610795: Enable this for testing::Bool().
class WebViewAccessibilityTest : public WebViewTest {};
INSTANTIATE_TEST_CASE_P(WebViewTests,
WebViewAccessibilityTest,
@@ -1257,7 +1258,7 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, SelectShowHide) {
// Important, pass mouse click to embedder in order to transfer focus. Note
// that SelectControlWaiter may be waited ealier than click is completed.
- LeftMouseClick mouse_click(embedder_contents);
+ LeftMouseClick mouse_click(GetParam() ? guest_contents : embedder_contents);
SelectControlWaiter select_control_waiter;
for (int i = 0; i < 5; ++i) {
« no previous file with comments | « no previous file | chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698