content/browser/web_contents/web_contents_view_child_frame.cc - Issue 1934703002: Fix keyboard focus for OOPIF-<webview>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_child_frame.cc

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment requested by dcheng. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_view_child_frame.cc

diff --git a/content/browser/web_contents/web_contents_view_child_frame.cc b/content/browser/web_contents/web_contents_view_child_frame.cc

index 78ab6c6d18a5c9d584751bf57640613b3284fca6..eb7a49f8bff42ccd856be71e910385a45e8acdda 100644

--- a/content/browser/web_contents/web_contents_view_child_frame.cc

+++ b/content/browser/web_contents/web_contents_view_child_frame.cc

@@ -141,7 +141,8 @@ void WebContentsViewChildFrame::GotFocus() {

}

void WebContentsViewChildFrame::TakeFocus(bool reverse) {

- NOTREACHED();

+ // TODO(avallee): http://crbug.com/610819 Advance focus to next element in

+ // embedder

nasko 2016/07/28 16:43:05 nit: "in outer WebContents"? Also, end the comment

}

void WebContentsViewChildFrame::ShowContextMenu(