third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 1934703002: Fix keyboard focus for OOPIF-<webview>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed WebViewTests/WebViewTest.SelectShowHide/1 browser_test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index fd50765a3d526faa0323d6805470ffd402e00f3a..1cf6bda0ea8b3f81aaea673f87d1cdb813cbf18e 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -2964,6 +2964,13 @@ void WebViewImpl::focusDocumentView(WebFrame* frame)

page()->focusController().focusDocumentView(frame->toImplBase()->frame(), false /* notifyEmbedder */);

}

+void WebViewImpl::unfocusDocumentView(WebFrame* frame)

+ LocalFrame* focusedFrame = page()->focusController().focusedFrame();

+ DCHECK(!focusedFrame || focusedFrame == frame->toImplBase()->frame());

+ page()->focusController().focusDocumentView(nullptr /* frame */, false /* notifyEmbedder */);

void WebViewImpl::setInitialFocus(bool reverse)

{

if (!m_page)