Fix keyboard focus for OOPIF-<webview>.

content/browser/web_contents/web_contents_impl.h

Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 645b6c7408ed7b6b940cf0b0a7577a276a0b4937..a1a6c70cf7e6c4854a4f2725fd6ffbfbf663e5f6 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -463,6 +463,7 @@ class CONTENT_EXPORT WebContentsImpl
   void EnsureOpenerProxiesExist(RenderFrameHost* source_rfh) override;
   std::unique_ptr<WebUIImpl> CreateWebUIForRenderFrameHost(
       const GURL& url) override;
+  void SetFocusedFrame(FrameTreeNode* node, SiteInstance* source) override;
 
   // RenderViewHostDelegate ----------------------------------------------------
   RenderViewHostDelegateView* GetDelegateView() override;
@@ -810,26 +811,31 @@ private:
   // corresponding FrameTreeNode.
   struct WebContentsTreeNode {
    public:
-    WebContentsTreeNode();
+    WebContentsTreeNode(WebContentsImpl* inner);
     ~WebContentsTreeNode();
 
-    typedef std::set<WebContentsTreeNode*> ChildrenSet;
+    typedef std::unordered_map<int, WebContentsTreeNode*> ChildrenMap;
 
     void ConnectToOuterWebContents(WebContentsImpl* outer_web_contents,
                                    RenderFrameHostImpl* outer_contents_frame);
 
-    WebContentsImpl* outer_web_contents() { return outer_web_contents_; }
-    int outer_contents_frame_tree_node_id() {
+    WebContentsImpl* outer_web_contents() const { return outer_web_contents_; }
+    int outer_contents_frame_tree_node_id() const {
       return outer_contents_frame_tree_node_id_;
     }
 
+    WebContentsImpl* find_contents_for_frame(int frame_id) const;

[lfg, 2016/05/06 21:23:33]

Use FindContentsForFrame(int). Unix-style naming is only for accessors.

[avallee, 2016/05/11 18:26:11]

Done.

+
    private:
-    // The outer WebContents.
+    // The web contents that owns this node
+    WebContentsImpl* const inner_web_contents_;
+
+    // The outer WebContents
     WebContentsImpl* outer_web_contents_;
     // The ID of the FrameTreeNode in outer WebContents that is hosting us.
     int outer_contents_frame_tree_node_id_;
     // List of inner WebContents that we host.
-    ChildrenSet inner_web_contents_tree_nodes_;
+    ChildrenMap inner_web_contents_tree_nodes_;
   };
 
   // See WebContents::Create for a description of these parameters.
@@ -968,6 +974,9 @@ private:
   // response. This won't actually update the throbber, but it will get picked
   // up at the next animation step if the throbber is going.
   void SetNotWaitingForResponse() { waiting_for_response_ = false; }

[lfg, 2016/05/06 21:23:33]

Add blank line, since the comment above doesn't apply here.

[avallee, 2016/05/11 18:26:11]

Done.

+  void SetFocusedFrameInternal(FrameTreeNode* node,
+                               SiteInstance* source,
+                               bool can_visit_outer_contents);
 
   // Navigation helpers --------------------------------------------------------
   //