Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nasko@ comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 void resizeWithTopControls( 181 void resizeWithTopControls(
182 const WebSize&, 182 const WebSize&,
183 float topControlsHeight, 183 float topControlsHeight,
184 bool topControlsShrinkLayout) override; 184 bool topControlsShrinkLayout) override;
185 WebFrame* mainFrame() override; 185 WebFrame* mainFrame() override;
186 WebFrame* findFrameByName( 186 WebFrame* findFrameByName(
187 const WebString& name, WebFrame* relativeToFrame) override; 187 const WebString& name, WebFrame* relativeToFrame) override;
188 WebLocalFrame* focusedFrame() override; 188 WebLocalFrame* focusedFrame() override;
189 void setFocusedFrame(WebFrame*) override; 189 void setFocusedFrame(WebFrame*) override;
190 void focusDocumentView(WebFrame*) override; 190 void focusDocumentView(WebFrame*) override;
191 void unfocusDocumentView() override;
191 void setInitialFocus(bool reverse) override; 192 void setInitialFocus(bool reverse) override;
192 void clearFocusedElement() override; 193 void clearFocusedElement() override;
193 bool scrollFocusedEditableElementIntoRect(const WebRect&) override; 194 bool scrollFocusedEditableElementIntoRect(const WebRect&) override;
194 void smoothScroll(int targetX, int targetY, long durationMs) override; 195 void smoothScroll(int targetX, int targetY, long durationMs) override;
195 void zoomToFindInPageRect(const WebRect&); 196 void zoomToFindInPageRect(const WebRect&);
196 void advanceFocus(bool reverse) override; 197 void advanceFocus(bool reverse) override;
197 void advanceFocusAcrossFrames(WebFocusType, WebRemoteFrame* from, WebLocalFr ame* to) override; 198 void advanceFocusAcrossFrames(WebFocusType, WebRemoteFrame* from, WebLocalFr ame* to) override;
198 double zoomLevel() override; 199 double zoomLevel() override;
199 double setZoomLevel(double) override; 200 double setZoomLevel(double) override;
200 void zoomLimitsChanged(double minimumZoomLevel, double maximumZoomLevel) ove rride; 201 void zoomLimitsChanged(double minimumZoomLevel, double maximumZoomLevel) ove rride;
(...skipping 574 matching lines...) Expand 10 before | Expand all | Expand 10 after
775 bool m_overrideCompositorVisibility; 776 bool m_overrideCompositorVisibility;
776 }; 777 };
777 778
778 // We have no ways to check if the specified WebView is an instance of 779 // We have no ways to check if the specified WebView is an instance of
779 // WebViewImpl because WebViewImpl is the only implementation of WebView. 780 // WebViewImpl because WebViewImpl is the only implementation of WebView.
780 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 781 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
781 782
782 } // namespace blink 783 } // namespace blink
783 784
784 #endif 785 #endif
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698