Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Side by Side Diff: content/browser/web_contents/web_contents_view_child_frame.cc

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nasko@ comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_view_child_frame.h" 5 #include "content/browser/web_contents/web_contents_view_child_frame.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "content/browser/frame_host/render_widget_host_view_child_frame.h" 8 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
9 #include "content/browser/web_contents/web_contents_impl.h" 9 #include "content/browser/web_contents/web_contents_impl.h"
10 #include "content/public/browser/web_contents_view_delegate.h" 10 #include "content/public/browser/web_contents_view_delegate.h"
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 134
135 void WebContentsViewChildFrame::UpdateDragCursor(WebDragOperation operation) { 135 void WebContentsViewChildFrame::UpdateDragCursor(WebDragOperation operation) {
136 NOTREACHED(); 136 NOTREACHED();
137 } 137 }
138 138
139 void WebContentsViewChildFrame::GotFocus() { 139 void WebContentsViewChildFrame::GotFocus() {
140 NOTREACHED(); 140 NOTREACHED();
141 } 141 }
142 142
143 void WebContentsViewChildFrame::TakeFocus(bool reverse) { 143 void WebContentsViewChildFrame::TakeFocus(bool reverse) {
144 NOTREACHED(); 144 // TODO(avallee): http://crbug.com/610819 Advance focus to next element in
145 // outer WebContents.
145 } 146 }
146 147
147 void WebContentsViewChildFrame::ShowContextMenu( 148 void WebContentsViewChildFrame::ShowContextMenu(
148 RenderFrameHost* render_frame_host, 149 RenderFrameHost* render_frame_host,
149 const ContextMenuParams& params) { 150 const ContextMenuParams& params) {
150 NOTREACHED(); 151 NOTREACHED();
151 } 152 }
152 153
153 void WebContentsViewChildFrame::StartDragging( 154 void WebContentsViewChildFrame::StartDragging(
154 const DropData& drop_data, 155 const DropData& drop_data,
155 WebDragOperationsMask ops, 156 WebDragOperationsMask ops,
156 const gfx::ImageSkia& image, 157 const gfx::ImageSkia& image,
157 const gfx::Vector2d& image_offset, 158 const gfx::Vector2d& image_offset,
158 const DragEventSourceInfo& event_info) { 159 const DragEventSourceInfo& event_info) {
159 NOTREACHED(); 160 NOTREACHED();
160 } 161 }
161 162
162 } // namespace content 163 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698