Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: content/browser/frame_host/render_frame_host_delegate.h

Issue 1934703002: Fix keyboard focus for OOPIF-<webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Fix tab focus change. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 12 matching lines...) Expand all
23 #include "ui/gfx/native_widget_types.h" 23 #include "ui/gfx/native_widget_types.h"
24 #endif 24 #endif
25 25
26 class GURL; 26 class GURL;
27 27
28 namespace IPC { 28 namespace IPC {
29 class Message; 29 class Message;
30 } 30 }
31 31
32 namespace content { 32 namespace content {
33 class FrameTreeNode;
33 class GeolocationServiceContext; 34 class GeolocationServiceContext;
34 class InterstitialPage; 35 class InterstitialPage;
35 class PageState; 36 class PageState;
36 class RenderFrameHost; 37 class RenderFrameHost;
37 class WakeLockServiceContext; 38 class WakeLockServiceContext;
38 class WebContents; 39 class WebContents;
39 struct AXEventNotificationDetails; 40 struct AXEventNotificationDetails;
40 struct ContextMenuParams; 41 struct ContextMenuParams;
41 struct TransitionLayerData; 42 struct TransitionLayerData;
42 43
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 // 173 //
173 // TODO(alexmos): This method currently supports cross-process postMessage, 174 // TODO(alexmos): This method currently supports cross-process postMessage,
174 // where we may need to create any missing proxies for the message's source 175 // where we may need to create any missing proxies for the message's source
175 // frame and its opener chain. It currently exists in WebContents due to a 176 // frame and its opener chain. It currently exists in WebContents due to a
176 // special case for <webview> guests, but this logic should eventually be 177 // special case for <webview> guests, but this logic should eventually be
177 // moved down into RenderFrameProxyHost::RouteMessageEvent when <webview> 178 // moved down into RenderFrameProxyHost::RouteMessageEvent when <webview>
178 // refactoring for --site-per-process mode is further along. See 179 // refactoring for --site-per-process mode is further along. See
179 // https://crbug.com/330264. 180 // https://crbug.com/330264.
180 virtual void EnsureOpenerProxiesExist(RenderFrameHost* source_rfh) {} 181 virtual void EnsureOpenerProxiesExist(RenderFrameHost* source_rfh) {}
181 182
183 // Set the |node| frame as focused in the current FrameTree as well as
184 // possibly changing focus in distinct but related FrameTrees (Guest, Embedder
185 // with separate tree).
186 virtual void SetFocusedFrame(FrameTreeNode* node, SiteInstance* source){};
alexmos 2016/05/12 20:28:39 nit: space before {} and no ; at the end
avallee 2016/05/16 20:26:43 Done.
187
182 // Creates a WebUI object for a frame navigating to |url|. If no WebUI 188 // Creates a WebUI object for a frame navigating to |url|. If no WebUI
183 // applies, returns null. 189 // applies, returns null.
184 virtual std::unique_ptr<WebUIImpl> CreateWebUIForRenderFrameHost( 190 virtual std::unique_ptr<WebUIImpl> CreateWebUIForRenderFrameHost(
185 const GURL& url); 191 const GURL& url);
186 192
187 protected: 193 protected:
188 virtual ~RenderFrameHostDelegate() {} 194 virtual ~RenderFrameHostDelegate() {}
189 }; 195 };
190 196
191 } // namespace content 197 } // namespace content
192 198
193 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_ 199 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698